57 lines
1.8 KiB
Plaintext
57 lines
1.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_a732aea5",
|
|
"filename": "novajoin/ipa.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 80,
|
|
"author": {
|
|
"id": 14250
|
|
},
|
|
"writtenOn": "2019-10-16T21:17:35Z",
|
|
"side": 1,
|
|
"message": "You are using a threading lock above, so I think you would want to log the thread ID, not the process ID ( threading.get_ident() ).",
|
|
"revId": "3267ed37571d97cb0ea4398ead056ea90c167619",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_64334a15",
|
|
"filename": "novajoin/ipa.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 80,
|
|
"author": {
|
|
"id": 11589
|
|
},
|
|
"writtenOn": "2019-10-17T13:42:12Z",
|
|
"side": 1,
|
|
"message": "While debugging we found that the cache\u0027s are being tied to processes, and shared between threads. We want to make sure that the cache\u0027s aren\u0027t being shared across PIDs rather than threads. Do you think there is value in tracking both?",
|
|
"parentUuid": "3fa7e38b_a732aea5",
|
|
"revId": "3267ed37571d97cb0ea4398ead056ea90c167619",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_f64efe36",
|
|
"filename": "novajoin/ipa.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 80,
|
|
"author": {
|
|
"id": 14250
|
|
},
|
|
"writtenOn": "2019-10-18T09:21:54Z",
|
|
"side": 1,
|
|
"message": "You are right, in that case identifying the precise thread isn\u0027t particularly useful.",
|
|
"parentUuid": "3fa7e38b_64334a15",
|
|
"revId": "3267ed37571d97cb0ea4398ead056ea90c167619",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |