21 lines
1.0 KiB
Plaintext
21 lines
1.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_d18273ff",
|
|
"filename": "novajoin/ipa.py",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 79,
|
|
"author": {
|
|
"id": 9914
|
|
},
|
|
"writtenOn": "2019-12-05T19:29:27Z",
|
|
"side": 1,
|
|
"message": "I think we are missing an assignment here.\n\nThe very first of these objects will define the ccache and put it in the environment.\n\nSubsequent objects though have api.isdone() set because of the call below to api.finalize(). They will not have self.ccache set - and so will be messed up.\n\nMaybe we need an assignment here:\n\nelse:\n self.ccache \u003d os.environ[\u0027KRB5CCNAME\u0027]\n\nwhich should have been set by the first object to go through this.\n\nAnd then -- maybe we need to enclose this in a lock to make sure two different caches are set up ..\n\nUnless we are sure only one of these objects exists.",
|
|
"revId": "87e306ec6206ccece00bb56a14cca1dad8f99c07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |