![lihaijing](/assets/img/avatar_default.png)
Some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by test tools. And add some relevant hacking files. Change-Id: I4b154a2e2898e316c61decf856547d57b1dcc2f8
27 lines
985 B
Python
27 lines
985 B
Python
# Copyright (c) 2017 OpenStack Foundation.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
import testtools
|
|
|
|
from hacking import checks
|
|
|
|
|
|
class HackingTestCase(testtools.TestCase):
|
|
def test_assert_true_instance(self):
|
|
self.assertEqual(1, len(list(checks.assert_true_instance(
|
|
"self.assertTrue(isinstance(e, "
|
|
"exception.BuildAbortException))"))))
|
|
|
|
self.assertEqual(
|
|
0, len(list(checks.assert_true_instance("self.assertTrue()"))))
|