x
/
ooi
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(2 comments)

Hi, some minor comments.

Also, can we have some unit tests for this case?

Patch-set: 5
This commit is contained in:
Gerrit User 91 2017-08-17 09:33:07 +00:00 committed by Gerrit Code Review
parent a213d49fa3
commit a89b87f169
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
73e744d6b1087ee694d9cbcb29c4f827caeaccc5 Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"key": {
"uuid": "9f436f4f_02cee161",
"filename": "ooi/api/helpers_neutron.py",
"patchSetId": 5
},
"lineNbr": 281,
"author": {
"id": 91
},
"writtenOn": "2017-08-17T09:33:07Z",
"side": 1,
"message": "Please remove this whitespace",
"revId": "73e744d6b1087ee694d9cbcb29c4f827caeaccc5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f436f4f_82bad1bd",
"filename": "ooi/api/helpers_neutron.py",
"patchSetId": 5
},
"lineNbr": 296,
"author": {
"id": 91
},
"writtenOn": "2017-08-17T09:33:07Z",
"side": 1,
"message": "This is to broad, but I assume that we can live with that",
"range": {
"startLine": 296,
"startChar": 19,
"endLine": 296,
"endChar": 28
},
"revId": "73e744d6b1087ee694d9cbcb29c4f827caeaccc5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}