x
/
opencafe
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 9364 2016-12-12 22:17:25 +00:00 committed by Gerrit Code Review
parent 9e6519c315
commit 4559436173
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "1a6eadb0_4bed9b8a",
"filename": "cafe/configurator/managers.py",
"patchSetId": 1
},
"lineNbr": 626,
"author": {
"id": 9364
},
"writtenOn": "2016-12-12T22:17:25Z",
"side": 1,
"message": "Is it worth adding safe accessors on the attributes of the module? Would that allow us to remove the new version dependency on setuptools?",
"revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_6b6df731",
"filename": "cafe/configurator/managers.py",
"patchSetId": 1
},
"lineNbr": 629,
"author": {
"id": 9364
},
"writtenOn": "2016-12-12T22:17:25Z",
"side": 1,
"message": "Would it make sense to do some checking/validation on all values in cafe.__path__ to handle the case where the correct directory does exist but is not in position 0?\n\n for path in cafe.__path__:\n if os.path.exists(os.path.join(path, \u0027plugins\u0027)):\n cafe_path \u003d os.path.join(path, \u0027plugins\u0027)\n break",
"revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a6eadb0_ebc66715",
"filename": "setup.py",
"patchSetId": 1
},
"lineNbr": 58,
"author": {
"id": 9364
},
"writtenOn": "2016-12-12T22:17:25Z",
"side": 1,
"message": "Could we remove this line if we do a safe access on the attribute (see comment in other file)?",
"revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}