Update patch set 1

Patch Set 1: Workflow+1

(3 comments)

Patch-set: 1

23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0

@@ -1,5 +1,51 @@
 {
   "comments": [
+    {
+      "key": {
+        "uuid": "fa48f94a_356a9a1b",
+        "filename": "cafe/configurator/managers.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 624,
+      "author": {
+        "id": 8603
+      },
+      "writtenOn": "2016-12-21T18:00:04Z",
+      "side": 1,
+      "message": "What is this line for? you aren\u0027t storing the result",
+      "range": {
+        "startLine": 624,
+        "startChar": 9,
+        "endLine": 624,
+        "endChar": 63
+      },
+      "revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa48f94a_95c6e614",
+        "filename": "cafe/configurator/managers.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 625,
+      "author": {
+        "id": 8603
+      },
+      "writtenOn": "2016-12-21T18:00:04Z",
+      "side": 1,
+      "message": "This isn\u0027t needed.  On the case where the assignment fails in both the try and the except it will raise an exception so None won\u0027t be returned",
+      "range": {
+        "startLine": 625,
+        "startChar": 8,
+        "endLine": 625,
+        "endChar": 17
+      },
+      "revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "1a6eadb0_4bed9b8a",
@@ -67,6 +113,29 @@
       "revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
       "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "fa48f94a_d53a2ee7",
+        "filename": "setup.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 8603
+      },
+      "writtenOn": "2016-12-21T18:00:04Z",
+      "side": 1,
+      "message": "I think version locking setuptools is a bad practice because it blocks dependencies that use new features in their setup.py.  For instance the the dependency links replacement that is coming soon.",
+      "range": {
+        "startLine": 58,
+        "startChar": 30,
+        "endLine": 58,
+        "endChar": 40
+      },
+      "revId": "23273b7c9cbbe2c0f440a4746be8f33d4ba35fe0",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
     }
   ]
 }