OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
|1 month ago|
|doc/source||2 years ago|
|priorities||6 months ago|
|specs||6 months ago|
|tests||2 years ago|
|.gitignore||2 years ago|
|.gitreview||1 month ago|
|.testr.conf||2 years ago|
|LICENSE||2 years ago|
|README.rst||2 years ago|
|requirements.txt||2 years ago|
|setup.cfg||4 months ago|
|setup.py||2 years ago|
|test-requirements.txt||2 years ago|
|tox.ini||2 years ago|
This git repository is used to hold approved design specifications for additions to the Pacemaker Resource Agents for OpenStack project. Reviews of the specs are done in gerrit, using a similar workflow to how we review and merge changes to the code itself. For specific policies around specification review, refer to the end of this document.
The layout of this repository is:
Where there are two sub-directories:
specs/<release>/approved: specifications approved but not yet implemented specs/<release>/implemented: implemented specifications
Developers proposing a specification should propose a new file in the
openstack-resource-agents-core will review the change in the usual manner for the OpenStack project, and eventually it will get merged if a consensus is reached. At this time the Launchpad blueprint is also approved. The developer is then free to propose code reviews to implement their specification. These reviews should be sure to reference the Launchpad blueprint in their commit message for tracking purposes.
Once all code for the feature is merged, the Launchpad blueprint is marked complete. As the developer of an approved specification it is your responsibility to mark your blueprint complete when all of the required patches have merged.
Periodically, someone from
openstack-resource-agents-core will move implemented specifications from the
approved directory to the
implemented directory. Whilst individual developers are welcome to propose this move for their implemented specifications, we have generally just done this in a batch at the end of the release cycle. It is important to create redirects when this is done so that existing links to the approved specification are not broken. Redirects aren't symbolic links, they are defined in a file which sphinx consumes. An example is at
This directory structure allows you to see what we thought about doing, decided to do, and actually got done. Users interested in functionality in a given release should only refer to the
You can find an example spec in
Additionally, we allow the proposal of specifications that do not have a developer assigned to them. These are proposed for review in the same manner as above, but are added to:
Specifications in this directory indicate the original author has either become unavailable, or has indicated that they are not going to implement the specification. The specifications found here are available as opportunities for people looking to get involved with the project. If you are interested in claiming a spec, start by posting a review for the specification that moves it from this directory to the next active release. Please set yourself as the new primary assignee and maintain the original author in the other contributors list.
For more information about working with gerrit, see http://docs.openstack.org/infra/manual/developers.html#development-workflow
To validate that the specification is syntactically correct (i.e. get more confidence in the Jenkins result), please execute the following command:
tox, the documentation will be available for viewing in HTML format in the
There are a number of review policies which
openstack-resource-agents-core will apply when reviewing proposed specifications. They are:
Proposed changes which are trivial (very small amounts of code) and don't change any of our public APIs are sometimes not required to provide a specification. In these cases a Launchpad blueprint is considered sufficient. These proposals are approved during the open discussion portion of the weekly HA IRC meeting. If you think your proposed feature is trivial and meets these requirements, we recommend you bring it up for discussion there before writing a full specification.
Specifications are only approved for a single release. If your specification was previously approved but not implemented (or not completely implemented), then you must seek re-approval for the specification. You can re-propose your specification by doing the following:
openstack-resource-agents-corewill merge specifications which meet these requirements with a single +2.
For specifications that depend on code in other OpenStack projects merging we will not approve the openstack-resource-agents specification until the code in that other project has merged. To indicate your specification is in this state, please use the Depends-On git commit message tag. The correct format is Depends-On: <change id of other work>.
openstack-resource-agents-core can approve the specification at any time, but it wont merge until the code we need to land in the other project has merged as well.