Update patch set 2
Patch Set 2: (2 comments) Patch-set: 2 Reviewer: Gerrit User 17243 <17243@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
parent
0222961d76
commit
348b4f3405
50
bea989c5b076b1ead177ab81d21ef8ebb1392803
Normal file
50
bea989c5b076b1ead177ab81d21ef8ebb1392803
Normal file
@ -0,0 +1,50 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3afc51ec_3b9df059",
|
||||
"filename": "ocf/neutron-ha-tool",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 233,
|
||||
"author": {
|
||||
"id": 17243
|
||||
},
|
||||
"writtenOn": "2016-03-14T08:52:23Z",
|
||||
"side": 1,
|
||||
"message": "This assumes that $statefile can be created.\nI think it should raise an error if this command is unsuccessful, for example:\n\n touch \"$statefile\"\n rc\u003d$?\n if [ $rc -ne 0 ]; then\n ocf_log err \"Neutron HA Tool (neutron-ha-tool) failed to create statefile: $statefile\"\n return $OCF_ERR_GENERIC\n fi",
|
||||
"range": {
|
||||
"startLine": 233,
|
||||
"startChar": 4,
|
||||
"endLine": 233,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "bea989c5b076b1ead177ab81d21ef8ebb1392803",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3afc51ec_3e45de16",
|
||||
"filename": "ocf/neutron-ha-tool",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 263,
|
||||
"author": {
|
||||
"id": 17243
|
||||
},
|
||||
"writtenOn": "2016-03-14T08:52:23Z",
|
||||
"side": 1,
|
||||
"message": "Same here, it should raise and error if $statefile can\u0027t be removed for some reason.",
|
||||
"range": {
|
||||
"startLine": 263,
|
||||
"startChar": 4,
|
||||
"endLine": 263,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "bea989c5b076b1ead177ab81d21ef8ebb1392803",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user