From d145d744e0278cbb80cba4ee5826b72b85205545 Mon Sep 17 00:00:00 2001 From: Gerrit User 2394 <2394@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 30 Jan 2017 17:05:12 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Label: Workflow=0 --- ccc7435cb16fb451fc8131a7b6abfc375e3a7f13 | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 ccc7435cb16fb451fc8131a7b6abfc375e3a7f13 diff --git a/ccc7435cb16fb451fc8131a7b6abfc375e3a7f13 b/ccc7435cb16fb451fc8131a7b6abfc375e3a7f13 new file mode 100644 index 0000000..d106580 --- /dev/null +++ b/ccc7435cb16fb451fc8131a7b6abfc375e3a7f13 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "3a461143_55ae9081", + "filename": "ocf/NovaCompute", + "patchSetId": 1 + }, + "lineNbr": 334, + "author": { + "id": 2394 + }, + "writtenOn": "2017-01-30T17:05:12Z", + "side": 1, + "message": "The change looks essentially fine to me but there\u0027s a nitpick which makes me pause before giving a +1: I\u0027m not too keen on how far the local variable declaration is split from its usage - that impacts readability and maintainability. You could instead put\n\n local validate_host\u003d1\n\njust before this if clause, and then just drop the else part. Declaring variables at the start of a function is usually just an unnecessary throwback to the ancient era of C programming before C99 :-)\n\nOf course, that wouldn\u0027t be a concern if this function wasn\u0027t already horribly overgrown, but even prior to any \"extract function\" refactoring, it makes sense to keep related code in the same part of the function.", + "revId": "ccc7435cb16fb451fc8131a7b6abfc375e3a7f13", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file