Update patch set 2
Patch Set 2: (2 comments) Patch-set: 2 Label: Workflow=0
This commit is contained in:
parent
b6f4f6ce0a
commit
eaf7c05eda
38
0d4666fb5c8b4939c02559e2f87fbcc7e208d086
Normal file
38
0d4666fb5c8b4939c02559e2f87fbcc7e208d086
Normal file
@ -0,0 +1,38 @@
|
|||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "3a461143_f51bfcc7",
|
||||||
|
"filename": "ocf/NovaCompute",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 252,
|
||||||
|
"author": {
|
||||||
|
"id": 2394
|
||||||
|
},
|
||||||
|
"writtenOn": "2017-01-30T17:08:29Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Same comment as in previous review - there\u0027s no good reason to separate the declaration from its usage, and this makes the code worse given the horribly long function.",
|
||||||
|
"revId": "0d4666fb5c8b4939c02559e2f87fbcc7e208d086",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "3a461143_f5493cb8",
|
||||||
|
"filename": "ocf/NovaCompute",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 338,
|
||||||
|
"author": {
|
||||||
|
"id": 2394
|
||||||
|
},
|
||||||
|
"writtenOn": "2017-01-30T17:08:29Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "I\u0027m not sure of nova\u0027s precedence rules but I assume you consciously decided not to put a break here, to match nova\u0027s behaviour in case of overlapping config parameters?",
|
||||||
|
"revId": "0d4666fb5c8b4939c02559e2f87fbcc7e208d086",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user