Browse Source

Temporary ignore bashate E006 errors

The currently available bashate releases are considering heredocs as
normal code lines, hence lines longer than 79 columns in these sections
are also considered as E006 violations. As the OCF scripts are
containing lots of heredocs, we are affected by this behaviour.
However, there is a commit in the bashate repository (649c7dc799)
which modifies bashate to ignore long lines in heredocs.

Currently there is no bashate release which contains the above commit,
so we ignore E006 errors until a new bashate released.

Change-Id: I33a9737ce1ec7eddab0b24ddedefe5c17da03b7a
Partial-Bug: #1550203
Signed-off-by: Norbert Illes <norbert.e.illes@ericsson.com>
Norbert Illes 3 years ago
parent
commit
fa93525cea
1 changed files with 10 additions and 1 deletions
  1. 10
    1
      tox.ini

+ 10
- 1
tox.ini View File

@@ -7,7 +7,16 @@ whitelist_externals = bash
7 7
 
8 8
 [testenv:bashate]
9 9
 deps = bashate
10
-commands = bash -c "bashate --verbose {toxinidir}/ocf/*"
10
+# NOTE: We ignore E006 violations (--ignore E006) only temporary.
11
+# The reason is that the currently available bashate versions (<=0.4.0) are
12
+# considering heredocs as normal code lines, hence lines longer than 79 columns
13
+# in these sections are also considered as E006 violations.
14
+# Commit 649c7dc79948 in bashate repository modifies bashate to ignore long
15
+# lines in heredocs, but currently there is no bashate release which contains
16
+# this commit.
17
+# TODO: After a new bashate released, '--ignore E006' should be deleted and the
18
+# newer bashate version should be specified as a dependency.
19
+commands = bash -c "bashate --ignore E006 --verbose {toxinidir}/ocf/*"
11 20
 
12 21
 [testenv:syntax-check]
13 22
 setenv =

Loading…
Cancel
Save