f6c80a8c25
Patch Set 4: Code-Review+1 (1 comment) Patch-set: 4 Reviewer: Gerrit User 2062 <2062@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1
75 lines
2.3 KiB
Plaintext
75 lines
2.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "1af94dfe_1edae978",
|
|
"filename": "ocf/neutron-ha-tool",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 191,
|
|
"author": {
|
|
"id": 2062
|
|
},
|
|
"writtenOn": "2016-03-15T11:39:37Z",
|
|
"side": 1,
|
|
"message": "Wouldn\u0027t this also need to be adapted for the new state file?\n\nI am somewhat unsure here what the \"status\" call is actually supposed to do as the RA Developers Guide doesn\u0027t even mention a \"status\" action. (Though most other agents here also implement it)",
|
|
"revId": "34447f8fa84b8e28d969cfea2638d6d888a328e8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1af94dfe_ba781891",
|
|
"filename": "ocf/neutron-ha-tool",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 191,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2016-03-15T14:07:19Z",
|
|
"side": 1,
|
|
"message": "@Ralf, thanks for spotting this! I investigated and it turns out it will never be used; see:\n\nhttp://bugs.clusterlabs.org/show_bug.cgi?id\u003d5271\nand\nhttps://bugs.launchpad.net/openstack-resource-agents/+bug/1557545",
|
|
"parentUuid": "1af94dfe_1edae978",
|
|
"revId": "34447f8fa84b8e28d969cfea2638d6d888a328e8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1af94dfe_5aaf54e3",
|
|
"filename": "ocf/neutron-ha-tool",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 191,
|
|
"author": {
|
|
"id": 2394
|
|
},
|
|
"writtenOn": "2016-03-15T14:07:39Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "1af94dfe_1edae978",
|
|
"revId": "34447f8fa84b8e28d969cfea2638d6d888a328e8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "1af94dfe_d0ad008a",
|
|
"filename": "ocf/neutron-ha-tool",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 191,
|
|
"author": {
|
|
"id": 2062
|
|
},
|
|
"writtenOn": "2016-03-15T15:47:05Z",
|
|
"side": 1,
|
|
"message": "Thanks for clarifying",
|
|
"parentUuid": "1af94dfe_ba781891",
|
|
"revId": "34447f8fa84b8e28d969cfea2638d6d888a328e8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |