From ccff42c130ea58c646b21e33465bc15c1c9fb893 Mon Sep 17 00:00:00 2001 From: Gerrit User 17920 <17920@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 22 Jan 2018 03:21:05 +0000 Subject: [PATCH] Update patch set 8 Patch Set 8: Code-Review-1 (1 comment) Patch-set: 8 Label: Code-Review=-1 --- a87d16097269e1ea0f7b07ed5c9323c80652fbd5 | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 a87d16097269e1ea0f7b07ed5c9323c80652fbd5 diff --git a/a87d16097269e1ea0f7b07ed5c9323c80652fbd5 b/a87d16097269e1ea0f7b07ed5c9323c80652fbd5 new file mode 100644 index 0000000..d6f9252 --- /dev/null +++ b/a87d16097269e1ea0f7b07ed5c9323c80652fbd5 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "7f96bb07_1f2060f7", + "filename": "os_xenapi/cmd/bootstrap.py", + "patchSetId": 8 + }, + "lineNbr": 33, + "author": { + "id": 17920 + }, + "writtenOn": "2018-01-22T03:21:05Z", + "side": 1, + "message": "I guess this should be in the main function instead. Otherwise it will invoked at anywhere import this module. e.g. it may break the UT if UT env is not allowed to create new the log file?", + "revId": "a87d16097269e1ea0f7b07ed5c9323c80652fbd5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file