openstack
/
ovn-bgp-agent
Code Issues Proposed changes

Increase unittest coverage for privileged linux_net 

Change-Id: I0bda0af6b70617a911929a32bf8f9e7ec779a9d9
This commit is contained in:
Luis Tomas Bolivar 2022-03-22 15:02:37 +01:00
parent f9d06fb48b
commit 1852cff8e5
1 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
ovn_bgp_agent/tests/unit/privileged/test_linux_net.py
View File

@ -149,8 +149,8 @@ class TestPrivilegedLinuxNet(test_base.TestCase):
iface_dict = {'fake-dev': dev}
self.fake_ndb.interfaces = iface_dict
priv_linux_net.delete_device('fake-dev')
dev.remove.assert_called_once_with()
priv_linux_net.delete_device('fake-dev-2')
dev.remove.assert_not_called()
def test_route_create(self):
fake_route = {'dst': 'default',
@ -167,6 +167,12 @@ class TestPrivilegedLinuxNet(test_base.TestCase):
priv_linux_net.route_delete(fake_route)
fake_route.__enter__().remove.assert_called_once_with()
def test_route_delete_keyerror(self):
fake_route = mock.MagicMock()
self.fake_ndb.routes.__getitem__.side_effect = KeyError
priv_linux_net.route_delete(fake_route)
fake_route.__enter__().remove.assert_not_called()
@mock.patch.object(priv_linux_net, 'set_device_status')
def test_ensure_vlan_device_for_network(self, mock_dev_status):
priv_linux_net.ensure_vlan_device_for_network('fake-br', 10)
@ -209,6 +215,19 @@ class TestPrivilegedLinuxNet(test_base.TestCase):
priv_linux_net.rule_create(fake_rule)
self.fake_ndb.rules.create.assert_not_called()
def test_rule_delete(self):
fake_rule = mock.MagicMock()
rules_dict = {'fake-rule': fake_rule}
self.fake_ndb.rules = rules_dict
priv_linux_net.rule_delete('fake-rule')
fake_rule.remove.assert_called_once()
def test_rule_delete_keyerror(self):
fake_rule = mock.MagicMock()
self.fake_ndb.rules.__getitem__.side_effect = KeyError
priv_linux_net.rule_delete(fake_rule)
fake_rule.__enter__().remove.assert_not_called()
def test_delete_ip_rules(self):
rule0 = mock.MagicMock()
rule1 = mock.MagicMock()
@ -342,6 +361,13 @@ class TestPrivilegedLinuxNet(test_base.TestCase):
'del', dst=self.ipv6, family=AF_INET6,
lladdr=self.mac, ifindex=mock.ANY, state=mock.ANY)
def test_del_ip_nei_index_error(self):
self.fake_iproute.link_lookup.side_effect = IndexError
priv_linux_net.del_ip_nei(self.ip, self.mac, self.dev)
self.fake_iproute.link_lookup.assert_called_once_with(ifname=self.dev)
self.fake_iproute.neigh.assert_not_called()
def test_add_unreachable_route(self):
priv_linux_net.add_unreachable_route('fake-vrf')
calls = [mock.call('ip', -4, 'route', 'add', 'vrf', 'fake-vrf',