x
/
packetary
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(3 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 18205 2017-01-17 09:47:41 +00:00 committed by Gerrit Code Review
parent 88636060e3
commit 8c52709d50
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
f0395fcd867b5763731172cba24379583a453025 Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "7a3c09a3_4ce462ab",
"filename": "packetary/objects/packages_tree.py",
"patchSetId": 2
},
"lineNbr": 74,
"author": {
"id": 18205
},
"writtenOn": "2017-01-17T09:47:41Z",
"side": 1,
"message": "need to sort results by version",
"range": {
"startLine": 74,
"startChar": 21,
"endLine": 74,
"endChar": 38
},
"revId": "f0395fcd867b5763731172cba24379583a453025",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a3c09a3_ac9ce60f",
"filename": "packetary/objects/packages_tree.py",
"patchSetId": 2
},
"lineNbr": 79,
"author": {
"id": 18205
},
"writtenOn": "2017-01-17T09:47:41Z",
"side": 1,
"message": "I am sorry, I forget to add key\u003dlambda x: x.version in my comment.",
"range": {
"startLine": 79,
"startChar": 30,
"endLine": 79,
"endChar": 36
},
"revId": "f0395fcd867b5763731172cba24379583a453025",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a3c09a3_eca26e4a",
"filename": "packetary/objects/packages_tree.py",
"patchSetId": 2
},
"lineNbr": 89,
"author": {
"id": 18205
},
"writtenOn": "2017-01-17T09:47:41Z",
"side": 1,
"message": "the same, need do specify custom key function.",
"range": {
"startLine": 89,
"startChar": 12,
"endLine": 89,
"endChar": 14
},
"revId": "f0395fcd867b5763731172cba24379583a453025",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}