x/packstack
Code Issues Proposed changes

Made packstack.installer.setup_params pep8 compliant and added unit test for this module

Browse Source 
Change-Id: Iff9d3f52ba3bc845d7bf01816dae1b4160581a3f
This commit is contained in:
Martin Magr
2013-02-28 17:00:42 +01:00
parent efdd25cb16
commit 0fdc119fcd
6 changed files with 358 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packstack/installer/setup_controller.py
View File

@@ -105,7 +105,7 @@ class Controller(object):
def getGroupByName(self, groupName):
for group in self.getAllGroups():
if group.getKey("GROUP_NAME") == groupName:
if group.GROUP_NAME == groupName:
return group
return None
@@ -114,7 +114,7 @@ class Controller(object):
def __getGroupIndexByDesc(self, name):
for group in self.getAllGroups():
if group.getKey("GROUP_NAME") == name:
if group.GROUP_NAME == name:
return self.__GROUPS.index(group)
return None
@@ -131,14 +131,13 @@ class Controller(object):
def getParamByName(self, paramName):
for group in self.getAllGroups():
param = group.getParamByName(paramName)
if param:
return param
if paramName in group.parameters:
return group.parameters[paramName]
return None
def getParamKeyValue(self, paramName, keyName):
param = self.getParamByName(paramName)
if param:
return param.getKey(keyName)
return getattr(param, keyName)
else:
return None