x/packstack
Code Issues Proposed changes

Adds error checking when puppet fails internally

Browse Source 
Adds regular expressions to the puppet error
check for the case in which the puppet
installation is broken.

Change-Id: Ic0da9605bdc7169d94ed43620ed2f5e6292301e4
Fixes: rhbz#958587
This commit is contained in:
Ivan Chavero
2013-10-15 00:43:04 -06:00
parent 6358907b11
commit 2e0ec8dfc2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packstack/modules/puppet.py
View File

@@ -15,7 +15,8 @@ re_error = re.compile(
'err:|Syntax error at|^Duplicate definition:|^Invalid tag|' 'err:|Syntax error at|^Duplicate definition:|^Invalid tag|'
'^No matching value for selector param|^Parameter name failed:|Error:|' '^No matching value for selector param|^Parameter name failed:|Error:|'
'^Invalid parameter|^Duplicate declaration:|^Could not find resource|' '^Invalid parameter|^Duplicate declaration:|^Could not find resource|'
'^Could not parse for|^\/usr\/bin\/env\: jruby\: No such file or directory' '^Could not parse for|^/usr/bin/puppet:\d+: .+|.+\(LoadError\)|'
'^\/usr\/bin\/env\: jruby\: No such file or directory'
) )
re_ignore = re.compile( re_ignore = re.compile(
# Puppet preloads a provider using the mysql command before it is installed # Puppet preloads a provider using the mysql command before it is installed