packaging: Add engine-upgrade utility

Introducing engine-upgrade utility, new utility for upgrading
ovirt-engine.

Using yum-plugin-versionlock, engine-setup will now lock existing
critical rpms, so the upgrade utility will take care of the complete
upgrade path.

Change-Id: Ic0bac004c8a8bf93f9b3d3bc7e2efe5b0ec2823a

basedefs.py

@@ -152,3 +152,7 @@ NO_COLOR="\033[0m"
 
 #space len size for color print
 SPACE_LEN=70
+
+RPM_LOCK_LIST = "ovirt-engine-genericapi ovirt-engine ovirt-engine-backend \
+ovirt-engine-jboss-deps ovirt-engine-webadmin-portal ovirt-engine-userportal \
+ovirt-engine-restapi ovirt-engine-config ovirt-engine-tools-common ovirt-engine-notification-service"

common_utils.py

@@ -569,6 +569,7 @@ def checkIfRhevmDbIsUp():
     logging.debug("checking if rhevm db is already installed and running..")
     (out, rc) = execSqlCommand(basedefs.DB_ADMIN, basedefs.DB_NAME, "select 1", True)
 
+# TODO: Support SystemD services
 class Service():
     def __init__(self, serviceName):
         self.wasStopped = False
@@ -624,3 +625,13 @@ class Service():
         logging.debug("executing action %s on service %s", serviceName, action)
         cmd = [basedefs.EXEC_SERVICE, serviceName, action]
         return execCmd(cmdList=cmd, usePipeFiles=True)
+
+def getColoredText (text, color):
+    ''' gets text string and color
+        and returns a colored text.
+        the color values are RED/BLUE/GREEN/YELLOW
+        everytime we color a text, we need to disable
+        the color at the end of it, for that
+        we use the NO_COLOR chars.
+    '''
+    return color + text + basedefs.NO_COLOR

engine-check-update

@@ -0,0 +1,2 @@
+#!/bin/bash
+/usr/share/ovirt-engine/scripts/engine-upgrade.py --check-update

engine-setup.py

@@ -1632,13 +1632,17 @@ def _handleJbossService(action, infoMsg, errMsg, printToStdout=False):
         print infoMsg
     utils.execCmd(cmdList=cmd,failOnError=True, msg=errMsg, usePipeFiles=True)
 
-#def _lockRpmVersion():
+def _lockRpmVersion():
-#    """
+    """
-#    Enters RHEVM rpm versions into yum version-lock
+    Enters rpm versions into yum version-lock
-#    """
+    """
-#    logging.debug("Locking rpms in yum-version-lock")
+    logging.debug("Locking rpms in yum-version-lock")
-#    cmd = "%s -q %s >> %s"%(basedefs.EXEC_RPM, basedefs.RPM_LOCK_LIST, basedefs.FILE_YUM_VERSION_LOCK)
+    cmd = [basedefs.EXEC_RPM, "-q"] + basedefs.RPM_LOCK_LIST.split()
-#    output, rc = utils.execExternalCmd(cmd, True, output_messages.ERR_YUM_LOCK)
+    output, rc = utils.execCmd(cmd, None, True, output_messages.ERR_YUM_LOCK)
+
+    with open(basedefs.FILE_YUM_VERSION_LOCK, "a") as f:
+        for rpm in output.splitlines():
+            f.write(rpm + "\n")
 
 def editPostgresConf():
     """
@@ -2238,7 +2242,7 @@ def main(configFile=None):
         runSequences()
 
         # Lock rhevm version
-        #_lockRpmVersion()
+        _lockRpmVersion()
 
         # Print info
         _addFinalInfoMsg()

engine-upgrade.py

@@ -0,0 +1,684 @@
+#!/usr/bin/python
+
+# Imports
+import sys
+import os
+import logging
+import traceback
+import pwd
+from optparse import OptionParser
+import yum
+from StringIO import StringIO
+import common_utils as utils
+import basedefs
+
+# Consts
+PRODUCT_NAME="oVirt-Engine"
+#TODO: Work with a real list here
+RPM_LIST = "ovirt-engine-notification-service ovirt-engine-genericapi ovirt-engine \
+ovirt-engine-tools-common ovirt-engine-backend \
+ovirt-engine-iso-uploader ovirt-engine-jboss-deps ovirt-engine-log-collector \
+ovirt-engine-userportal ovirt-engine-restapi ovirt-engine-config ovirt-engine-setup \
+ovirt-engine-dbscripts vdsm-bootstrap ovirt-engine-webadmin-portal"
+
+RPM_BACKEND = "ovirt-engine-backend"
+RPM_DBSCRIPTS = "ovirt-engine-dbscripts"
+RPM_SETUP = "ovirt-engine-setup"
+RPM_UPGRADE = "ovirt-engine-upgrade"
+
+SERVER_NAME = "127.0.0.1"
+BACKUP_DIR = "/usr/share/ovirt-engine/db-backups"
+BACKUP_FILE = "ovirt-engine_db_backup"
+LOG_PATH = "/var/log/ovirt-engine"
+LOG_FILE = "ovirt-engine-upgrade.log"
+
+YUM_EXEC = "/usr/bin/yum"
+ETL_SERVICE="/etc/init.d/ovirt-engine-etl"
+JBOSS_SERVICE_NAME="jboss-as"
+
+#MSGS
+MSG_ERROR_USER_NOT_ROOT = "Error: insufficient permissions for user %s, you must run with user root."
+MSG_NO_ROLLBACK = "Error: Current installation "
+MSG_RC_ERROR = "Return Code is not zero"
+MSG_INFO_NO_UPGRADE_AVAIL = "No updates available"
+MSG_INFO_UPGRADE_AVAIL = "%d Updates available:"
+MSG_ERROR_NO_ROLLBACK_AVAIL = "Error: Installed packages are missing from the yum repositories\n\
+Please check your yum repositories or use --no-yum-rollback"
+MSG_ERROR_NEW_SETUP_AVAIL="\nError: New %s rpm available via yum.\n\
+Please execute `yum update %s`, then re-execute '%s'.\n\
+To use the current %s rpm, execute '%s --force-current-setup-rpm'." % (RPM_SETUP, RPM_SETUP, RPM_UPGRADE, RPM_SETUP, RPM_UPGRADE)
+MSG_ERROR_BACKUP_DB = "Error: Database backup failed"
+MSG_ERROR_RESTORE_DB = "Error: Database restore failed"
+MSG_ERROR_DROP_DB = "Error: Database drop failed"
+MSG_ERROR_UPDATE_DB = "Error: Database update failed"
+MSG_ERROR_YUM_HISTORY_LIST = "Error: Can't get history from yum"
+MSG_ERROR_YUM_HISTORY_GETLAST = "Error: Can't find last install transaction in yum"
+MSG_ERROR_YUM_HISTORY_UNDO = "Error: Can't rollback yum"
+MSG_ERROR_YUM_LOCK = "Error: Can't edit yum lock file"
+MSG_ERROR_RPM_QUERY = "Error: Unable to retrieve rpm versions"
+MSG_ERROR_YUM_UPDATE = "Error: Yum update failed"
+MSG_ERROR_CHECK_LOG = "Error: Upgrade failed.\nplease check log at %s"
+MSG_ERR_FAILED_START_JBOSS_SERVICE = "Error: Can't start JBoss"
+MSG_ERR_FAILED_JBOSS_SERVICE_STILL_RUN = "Error: Can't stop jboss service. Please shut it down manually."
+MSG_ERR_FAILED_STP_JBOSS_SERVICE = "Error: Can't stop JBoss"
+MSG_ERR_FAILED_STATUS_JBOSS_SERVICE = "Error: Can't get JBoss service status"
+MSG_ERR_FAILED_START_SERVICE = "Error: Can't start the %s service"
+MSG_ERR_FAILED_STOP_SERVICE = "Error: Can't stop the %s service"
+MSG_ERR_SQL_CODE = "Failed running sql query"
+MSG_ERROR_JBOSS_PID = "Error: JBoss service is dead, but pid file exists"
+MSG_ERROR_YUM_TID = "Error: Yum transaction mismatch"
+
+MSG_INFO_DONE = "DONE"
+MSG_INFO_ERROR = "ERROR"
+MSG_INFO_REASON = " **Reason: %s**\n"
+MSG_INFO_STOP_JBOSS = "Stopping JBoss Service"
+MSG_INFO_BACKUP_DB = "Backing Up Database"
+MSG_INFO_YUM_UPDATE = "Updating rpms"
+MSG_INFO_DB_UPDATE = "Updating Database"
+MSG_INFO_RUN_POST = "Running post install configuration"
+MSG_ERROR_UPGRADE = "\n **Error: Upgrade failed, rolling back**"
+MSG_INFO_DB_RESTORE = "Restoring Database"
+MSG_INFO_YUM_ROLLBACK = "Rolling back rpms"
+MSG_INFO_NO_YUM_ROLLBACK = "Skipping yum rollback"
+MSG_INFO_START_JBOSS = "Starting JBoss"
+MSG_INFO_DB_BACKUP_FILE = "DB Backup available at "
+MSG_INFO_LOG_FILE = "Upgrade log available at"
+MSG_INFO_CHECK_UPDATE = "Checking for updates... (This may take several minutes)"
+MSG_INFO_UPGRADE_OK = "%s upgrade completed successfully!" %(PRODUCT_NAME)
+MSG_INFO_STOP_INSTALL_EXIT="Upgrade stopped, Goodbye."
+MSG_INFO_UPDATE_JBOSS_PROFILE="Updating JBoss Profile"
+
+MSG_ALERT_STOP_JBOSS="\nDuring the upgrade process, %s  will not be accessible.\n\
+All existing running virtual machines will continue but you will not be able to\n\
+start or stop any new virtual machines during the process.\n" %(PRODUCT_NAME)
+INFO_Q_STOP_JBOSS="Would you like to proceed"
+MSG_INFO_REPORTS="Perform the following steps to upgrade the history service \
+or the reporting package:\n\
+1. Execute: yum update ovirt-engine-reports*\n\
+2. Execute: ovirt-engine-dwh-setup\n\
+3. Execute: ovirt-engine-reports-setup"
+
+messages = []
+
+# Code
+def getOptions():
+    parser = OptionParser()
+    parser.add_option("-r", "--no-yum-rollback",
+                      action="store_false", dest="yum_rollback", default=True,
+                      help="don't rollback yum transaction")
+
+    parser.add_option("-u", "--unattended",
+                      action="store_true", dest="unattended_upgrade", default=False,
+                      help="unattended upgrade (this option will stop jboss service before upgrading ovirt-engine)")
+
+    parser.add_option("-s", "--force-current-setup-rpm",
+                      action="store_true", dest="force_current_setup_rpm", default=False,
+                      help="Ignore new %s rpm"%(RPM_SETUP))
+
+    parser.add_option("-c", "--check-update",
+                      action="store_true", dest="check_update", default=False,
+                      help="Check for available package updates")
+
+    (options, args) = parser.parse_args()
+    return (options, args)
+
+# TODO: Use the same facility for setup and upgrade
+def askYesNo(question=None):
+    """
+    service func to ask yes/no
+    input from user
+    """
+    message = StringIO()
+    userQuestion = "%s? (yes|no): "%(question)
+    logging.debug("asking user: %s"%userQuestion)
+    message.write(userQuestion)
+    message.seek(0)
+    answer = raw_input(message.read())
+    logging.debug("user answered: %s"%(answer))
+    answer = answer.lower()
+    if answer == "yes" or answer == "y":
+        return True
+    elif answer == "no" or answer == "n":
+        return False
+    else:
+        return askYesNo(question)
+
+def checkJbossService():
+    """
+    Ask user to stop jboss service before
+    upgrading ovirt-engine
+
+    returns: true if user choose to stop jboss
+    false otherwise
+    """
+    logging.debug("checking the status of jbossas service")
+    cmd = [basedefs.EXEC_SERVICE, JBOSS_SERVICE_NAME, "status"]
+    output, rc = utils.execCmd(cmd, None, False)
+
+    if rc == 0:
+        logging.debug("jbossas service is up and running")
+
+        print MSG_ALERT_STOP_JBOSS
+        answer = askYesNo(INFO_Q_STOP_JBOSS)
+
+        # If user choose yes -> return true (stop jbossas)
+        if answer:
+            return True
+        else:
+            logging.debug("User chose not to stop jboss")
+            return False
+
+    elif rc == 1:
+        # Proc is dead, pid exists
+        raise Exception(MSG_ERROR_JBOSS_PID)
+
+    elif rc == 3:
+        # If jboss is not running, we don't need to stop it
+        return True
+
+    else:
+        raise Exception(MSG_ERR_FAILED_STATUS_JBOSS_SERVICE)
+
+def initLogging():
+    global LOG_FILE
+    try:
+        if not os.path.isdir(LOG_PATH):
+            os.makedirs(LOG_PATH)
+        LOG_FILE = "%s/ovirt-engine-upgrade_%s.log"%(LOG_PATH, utils.getCurrentDateTime())
+        level = logging.DEBUG
+        # TODO: Move to mode="a"?
+        hdlr = logging.FileHandler(filename = LOG_FILE, mode='w')
+        fmts='%(asctime)s::%(levelname)s::%(module)s::%(lineno)d::%(name)s:: %(message)s'
+        dfmt='%Y-%m-%d %H:%M:%S'
+        fmt = logging.Formatter(fmts, dfmt)
+        hdlr.setFormatter(fmt)
+        logging.root.addHandler(hdlr)
+        logging.root.setLevel(level)
+    except:
+        logging.error(traceback.format_exc())
+        raise Exception("Failed to initiate logger")
+
+def _verifyUserPermissions():
+    username = pwd.getpwuid(os.getuid())[0]
+    if (username != 'root'):
+        print MSG_ERROR_USER_NOT_ROOT%(username)
+        sys.exit(1)
+
+def isDBUp():
+    """
+    check if ovirt-engine db is up
+    """
+    logging.debug("checking if %s db is already installed and running.."%basedefs.DB_NAME)
+    (out, rc) = utils.execSqlCommand(basedefs.DB_ADMIN, basedefs.DB_NAME, "select 1", True)
+
+class MYum():
+    def __init__(self):
+        self.updated = False
+        self.yumbase = None
+        self.upackages = []
+        self.ipackages = []
+        self.__initbase()
+        self.tid = None
+
+    def __initbase(self):
+        self.yumbase = yum.YumBase()
+        self.yumbase.conf.cache = False # Do not relay on existing cache
+        self.yumbase.cleanMetadata()
+        self.yumbase.cleanSqlite()
+
+    def _validateRpmLockList(self):
+        rpmLockList = []
+        for rpmName in basedefs.RPM_LOCK_LIST.split():
+            cmd = [basedefs.EXEC_RPM, "-q", rpmName]
+            output, rc = utils.execCmd(cmd)
+            if rc == 0:
+                rpmLockList.append(rpmName)
+
+        return rpmLockList
+
+    def _lock(self):
+        logging.debug("Yum lock started")
+
+        # Clear non-installed rpms from lock list
+        verifiedLockList = " ".join(self._validateRpmLockList())
+
+        # Create RPM lock list
+        # TODO: Use execCmd
+        cmd = "%s -q %s >> %s" % (basedefs.EXEC_RPM, verifiedLockList, basedefs.FILE_YUM_VERSION_LOCK)
+        output, rc = utils.execExternalCmd(cmd, True, MSG_ERROR_YUM_LOCK)
+
+        logging.debug("Yum lock completed successfully")
+
+    def _unlock(self):
+        logging.debug("Yum unlock started")
+        # Read file content
+        fd = file(basedefs.FILE_YUM_VERSION_LOCK)
+        fileText = fd.readlines()
+        fd.close()
+
+        # Change content:
+        fd = file(basedefs.FILE_YUM_VERSION_LOCK, 'w')
+        for line in fileText:
+            if not basedefs.ENGINE_RPM_NAME in line:
+                fd.write(line)
+        fd.close()
+        logging.debug("Yum unlock completed successfully")
+
+    def update(self):
+        self.tid = self.getLatestTid(False)
+        self._unlock()
+        try:
+            # yum update ovirt-engine
+            # TODO: Run test transaction
+            logging.debug("Yum update started")
+            cmd = [YUM_EXEC, "update", "-q", "-y"] + RPM_LIST.split()
+            output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_YUM_UPDATE)
+            logging.debug("Yum update completed successfully")
+            self.updated = True
+        finally:
+            self._lock()
+
+    def updateAvailable(self):
+        logging.debug("Yum list updates started")
+
+        # Get packages info from yum
+        rpms = RPM_LIST.split()
+        self._unlock()
+        try:
+            logging.debug("Getting list of packages to upgrade")
+            pkgs = self.yumbase.doPackageLists(patterns=rpms)
+        finally:
+            self._lock()
+
+        # Save update candidates
+        if pkgs.available:
+            self.upackages = [str(i) for i in sorted(pkgs.available)] # list of rpm names to update
+            logging.debug("%s Packages marked for update:"%(len(self.upackages)))
+            logging.debug(self.upackages)
+        else:
+            logging.debug("No packages marked for update")
+
+        # Save installed packages
+        self.ipackages = [str(i) for i in sorted(pkgs.installed)] # list of rpm names already installed
+        logging.debug("Installed packages:")
+        logging.debug(self.ipackages)
+
+        logging.debug("Yum list updated completed successfully")
+
+
+        # Return
+        if pkgs.available:
+            return True
+        else:
+            return False
+
+    def rollbackAvailable(self):
+        logging.debug("Yum rollback-avail started")
+
+        # Get All available packages in yum
+        rpms = RPM_LIST.split()
+        pkgs = self.yumbase.pkgSack.returnPackages(patterns=rpms)
+        available = [str(i) for i in sorted(pkgs)] # list of available rpm names
+        logging.debug("%s Packages available in yum:"%(len(available)))
+        logging.debug(available)
+
+        # Verify all installed packages available in yum
+        # self.ipackages is populated in updateAvailable
+        for installed in self.ipackages:
+            if installed not in available:
+                logging.debug("%s not available in yum"%(installed))
+                return False
+
+        logging.debug("Yum rollback-avail completed successfully")
+        return True
+
+    def rollback(self):
+        upgradeTid = self.getLatestTid(True)
+        if int(upgradeTid) <= int(self.tid):
+            logging.error("Mismatch in yum TID, target TID (%s) is not higher than %s" %(upgradeTid, self.tid))
+            raise Exception(MSG_ERROR_YUM_TID)
+
+        if self.updated:
+            self._unlock()
+            try:
+                # yum history undo 17
+                # Do rollback only if update went well
+                logging.debug("Yum rollback started")
+                cmd = [YUM_EXEC, "history", "-y", "undo", upgradeTid]
+                output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_YUM_HISTORY_UNDO)
+                logging.debug("Yum rollback completed successfully")
+            finally:
+                self._lock()
+        else:
+            logging.debug("No rollback needed")
+
+    def getLatestTid(self, updateOnly=False):
+        logging.debug("Yum getLatestTid started")
+        tid = None
+
+        # Get the list
+        cmd = [YUM_EXEC, "history", "list", self.upackages[0]]
+        output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_YUM_HISTORY_LIST)
+
+        # Parse last tid
+        for line in output.splitlines():
+            lsplit = line.split("|")
+            if len(lsplit) > 3:
+                if updateOnly:
+                    if 'Update' in lsplit[3].split() or "U" in lsplit[3].split():
+                        tid = lsplit[0].strip()
+                        break
+                else:
+                    if "Action" not in lsplit[3]: # Don't get header of output
+                        tid = lsplit[0].strip()
+                        break
+        if tid is None:
+            raise ValueError(MSG_ERROR_YUM_HISTORY_GETLAST)
+
+        logging.debug("Found TID: %s" %(tid))
+        logging.debug("Yum getLatestTid completed successfully")
+        return tid
+
+    def isCandidateForUpdate(self, rpm):
+        candidate = False
+        for package in self.upackages:
+            if rpm in package:
+                candidate = True
+        return candidate
+
+    def getUpdateCandidates(self):
+        return self.upackages
+
+class DB():
+    def __init__(self):
+        date = utils.getCurrentDateTime()
+        self.sqlfile = "%s/%s_%s.sql" % (BACKUP_DIR, BACKUP_FILE, date)
+        self.updated = False
+
+    def __del__(self):
+        if self.updated:
+            logging.debug(MSG_INFO_DB_BACKUP_FILE + self.sqlfile)
+            print "* %s %s" % (MSG_INFO_DB_BACKUP_FILE, self.sqlfile)
+
+    def backup(self):
+        # pg_dump -C -E UTF8  --column-inserts --disable-dollar-quoting  --disable-triggers -U postgres --format=p -f $dir/$file  ovirt-engine
+        logging.debug("DB Backup started")
+        #cmd = "%s -C -E UTF8 --column-inserts --disable-dollar-quoting  --disable-triggers -U %s --format=p -f %s %s"\
+            #%(basedefs.EXEC_PGDUMP, basedefs.DB_ADMIN, self.sqlfile, basedefs.DB_NAME)
+        cmd = [basedefs.EXEC_PGDUMP, "-C", "-E", "UTF8", "--column-inserts", "--disable-dollar-quoting", "--disable-triggers",
+                "-U", basedefs.DB_ADMIN, "--format=p", "-f", self.sqlfile, basedefs.DB_NAME]
+        output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_BACKUP_DB)
+        logging.debug("DB Backup completed successfully")
+
+    def restore(self):
+        #psql -U postgres -f <backup directory>/<backup_file>
+        if self.updated:
+            logging.debug("DB Restore started")
+            # Drop
+            cmd = [basedefs.EXEC_DROPDB, "-U", basedefs.DB_ADMIN, basedefs.DB_NAME]
+            output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_DROP_DB)
+
+            # Restore
+            cmd = [basedefs.EXEC_PSQL, "-U", basedefs.DB_ADMIN, "-f", self.sqlfile]
+            output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_RESTORE_DB)
+            logging.debug("DB Restore completed successfully")
+        else:
+            logging.debug("No DB Restore needed")
+
+    def update(self):
+        cwd = os.getcwd()
+        os.chdir(basedefs.DIR_DB_SCRIPTS)
+
+        # Make sure we always returning to cwd
+        try:
+            self.updated = True
+            logging.debug("DB Update started")
+            # ./upgrade.sh -s ${SERVERNAME} -d ${DATABASE} -u ${USERNAME};
+            #cmd = "%s -s %s -d %s -u %s"%(basedefs.FILE_DB_UPGRADE_SCRIPT, SERVER_NAME, basedefs.DB_NAME, basedefs.DB_ADMIN)
+            dbupgrade = os.path.join(basedefs.DIR_DB_SCRIPTS, basedefs.FILE_DB_UPGRADE_SCRIPT)
+            cmd = [dbupgrade, "-s", SERVER_NAME, "-d", basedefs.DB_NAME, "-u", basedefs.DB_ADMIN]
+            output, rc = utils.execCmd(cmd, None, True, MSG_ERROR_UPDATE_DB)
+            logging.debug("DB Update completed successfully")
+        finally:
+            os.chdir(cwd)
+
+def restartPostgresql():
+    """
+    restart the postgresql service
+    """
+
+    logging.debug("Restarting the postgresql service")
+    postgresql = utils.Service("postgresql")
+    postgresql.stop(True)
+    postgresql.start(True)
+
+    # Now we want to make sure the postgres service is up
+    # before we continue to the upgrade
+    utils.retry(isDBUp, tries=10, timeout=30)
+
+def stopJboss():
+    logging.debug("stopping jboss service.")
+    cmd = [basedefs.EXEC_SERVICE, JBOSS_SERVICE_NAME, "stop"]
+    output, rc = utils. execCmd(cmd, None, True, MSG_ERR_FAILED_STP_JBOSS_SERVICE)
+
+    # JBoss service sometimes return zero rc even if service is still up
+    if "[FAILED]" in output and "Timeout: Shutdown command was sent, but process is still running" in output:
+        raise OSError(MSG_ERR_FAILED_JBOSS_SERVICE_STILL_RUN)
+
+def startJboss():
+    logging.debug("starting jboss service.")
+    cmd = [basedefs.EXEC_SERVICE, JBOSS_SERVICE_NAME, "start"]
+    output, rc = utils.execCmd(cmd, None, True, MSG_ERR_FAILED_START_JBOSS_SERVICE)
+
+def runPost():
+    logging.debug("Running post script")
+    import post_upgrade as post
+    post.run()
+    logging.debug("Post script completed successfully")
+
+def runFunc(funcList, dispString):
+    print "%s..."%(dispString),
+    sys.stdout.flush()
+    spaceLen = basedefs.SPACE_LEN - len(dispString)
+    try:
+        for func in funcList:
+            func()
+        print ("[ " + utils.getColoredText(MSG_INFO_DONE, basedefs.GREEN) + " ]").rjust(spaceLen)
+    except:
+        print ("[ " + utils.getColoredText(MSG_INFO_ERROR, basedefs.RED) + " ]").rjust(spaceLen+3)
+        raise
+
+def isUpdateRelatedToDb(yumo):
+    """
+    Verifies current update needs DB manipulation (backup/update/rollback)
+    """
+
+    logging.debug("Verifing update is related to db")
+
+    related = False
+    for rpm in RPM_BACKEND, RPM_DBSCRIPTS:
+        if yumo.isCandidateForUpdate(rpm):
+            related = True
+
+    logging.debug("isUpdateRelatedToDb value is %s"%(str(related)))
+    return related
+
+def printMessages():
+    for msg in messages:
+        logging.info(msg)
+        print "* %s" % msg.strip()
+
+def addAdditionalMessages(addReports=False):
+    global messages
+    messages.append(MSG_INFO_LOG_FILE + " " + LOG_FILE)
+
+    if addReports:
+        messages.append(MSG_INFO_REPORTS)
+
+
+def stopDbRelatedServices(etlService, notificationService):
+    """
+    shut down etl and notifier services
+    in order to disconnect any open sessions to the db
+    """
+    # If the ovirt-engine-etl service is installed, then try and stop it.
+    if etlService.isServiceAvailable():
+        try:
+            etlService.stop(True)
+        except:
+            logging.warn("Failed to stop ovirt-engine-etl")
+            logging.warn(traceback.format_exc())
+            messages.append(MSG_ERR_FAILED_STOP_SERVICE % "ovirt-engine-etl")
+
+    # If the ovirt-engine-notifierd service is up, then try and stop it.
+    if notificationService.isServiceAvailable():
+        try:
+            (status, rc) = notificationService.status()
+            if utils.verifyStringFormat(status, ".*running.*"):
+                logging.debug("stopping ovirt-engine-notifierd service..")
+                notificationService.stop()
+        except:
+            logging.warn("Failed to stop ovirt-engine-notifierd service")
+            logging.warn(traceback.format_exc())
+            messages.append(MSG_ERR_FAILED_STOP_SERVICE % "ovirt-engine-notifierd")
+
+def startDbRelatedServices(etlService, notificationService):
+    """
+    bring back any service we stopped
+    we won't start services that are down
+    but weren't stopped by us
+    """
+    if etlService.isServiceAvailable():
+        (output, rc) = etlService.conditionalStart()
+        if rc != 0:
+            logging.warn("Failed to start ovirt-engine-etl")
+            messages.append(MSG_ERR_FAILED_START_SERVICE % "ovirt-engine-etl")
+
+    if notificationService.isServiceAvailable():
+        (output, rc) = notificationService.conditionalStart()
+        if rc != 0:
+            logging.warn("Failed to start ovirt-engine-notifierd: exit code %d" % rc)
+            messages.append(MSG_ERR_FAILED_START_SERVICE % "ovirt-engine-notifierd")
+
+def main(options):
+    rhyum = MYum()
+    db = DB()
+
+    # Check for upgrade, else exit
+    print MSG_INFO_CHECK_UPDATE
+    if not rhyum.updateAvailable():
+        logging.debug(MSG_INFO_NO_UPGRADE_AVAIL)
+        print MSG_INFO_NO_UPGRADE_AVAIL
+        sys.exit(0)
+    else:
+        updates = rhyum.getUpdateCandidates()
+        print MSG_INFO_UPGRADE_AVAIL % (len(updates))
+        for package in updates:
+            print " * %s" % package
+        if options.check_update:
+            sys.exit(100)
+
+    # Check for setup package
+    if rhyum.isCandidateForUpdate(RPM_SETUP) and not options.force_current_setup_rpm:
+        logging.debug(MSG_ERROR_NEW_SETUP_AVAIL)
+        print MSG_ERROR_NEW_SETUP_AVAIL
+        sys.exit(3)
+
+    # Make sure we will be able to rollback
+    if not rhyum.rollbackAvailable() and options.yum_rollback:
+        logging.debug(MSG_ERROR_NO_ROLLBACK_AVAIL)
+        print MSG_ERROR_NO_ROLLBACK_AVAIL
+        print MSG_ERROR_CHECK_LOG%(LOG_FILE)
+        sys.exit(2)
+
+    # No rollback in this case
+    try:
+        # We ask the user before stoping jboss or take command line option
+        if options.unattended_upgrade or checkJbossService():
+            # Stopping jboss
+            runFunc([stopJboss], MSG_INFO_STOP_JBOSS )
+        else:
+            # This means that user chose not to stop jboss
+            logging.debug("exiting gracefully")
+            print MSG_INFO_STOP_INSTALL_EXIT
+            sys.exit(0)
+
+        # Backup DB
+        if isUpdateRelatedToDb(rhyum):
+            runFunc([db.backup], MSG_INFO_BACKUP_DB)
+
+    except Exception as e:
+        print e
+        raise
+
+    # In case of failure, do rollback
+    try:
+        # yum update
+        runFunc([rhyum.update], MSG_INFO_YUM_UPDATE)
+
+        # define db connections services
+        etlService = utils.Service("ovirt-engine-etl")
+        notificationService = utils.Service("ovirt-engine-notifierd")
+
+        # check if update is relevant to db update
+        if isUpdateRelatedToDb(rhyum):
+            stopDbRelatedServices(etlService, notificationService)
+
+            # Update the db
+            runFunc([restartPostgresql, db.update], MSG_INFO_DB_UPDATE)
+
+            # Bring up any services we shut down before db upgrade
+            startDbRelatedServices(etlService, notificationService)
+
+        # post install conf
+        runFunc([runPost], MSG_INFO_RUN_POST)
+
+    except:
+        logging.error(traceback.format_exc())
+        logging.error("Rolling back update")
+
+        print MSG_ERROR_UPGRADE
+        print MSG_INFO_REASON%(sys.exc_info()[1])
+
+        # db restore
+        if isUpdateRelatedToDb(rhyum):
+            runFunc([db.restore], MSG_INFO_DB_RESTORE)
+
+        # yum rollback
+        if options.yum_rollback:
+            runFunc([rhyum.rollback], MSG_INFO_YUM_ROLLBACK)
+        else:
+            print MSG_INFO_NO_YUM_ROLLBACK
+            logging.debug("Skipping yum rollback")
+
+        raise
+
+    finally:
+        # start jboss
+        runFunc([startJboss], MSG_INFO_START_JBOSS)
+
+    # Print log location on success
+    addAdditionalMessages(etlService.isServiceAvailable())
+    print "\n%s\n" % MSG_INFO_UPGRADE_OK
+    printMessages()
+
+if __name__ == '__main__':
+    try:
+        # Must run as root
+        _verifyUserPermissions()
+
+        # Init logging facility
+        initLogging()
+
+        # get iso and domain from user arguments
+        (options, args) = getOptions()
+
+        main(options)
+
+    except SystemExit:
+        raise
+
+    except:
+        print MSG_ERROR_CHECK_LOG%(LOG_FILE)
+        logging.error(traceback.format_exc())
+        sys.exit(1)

output_messages.py

@@ -160,6 +160,7 @@ ERR_EXP_RUN_FUNCTION="Internal error, Please report this issue"
 #MAIN
 ERR_CHECK_LOG_FILE_FOR_MORE_INFO="Please check log file %s for more information"
 ERR_YUM_LOCK="Internal Error: Can't edit versionlock "
+ERR_RPM_QUERY="Internal Error: Can't query rpm versions"
 
 #_createDB
 ERR_DB_CREATE_FAILED="Database creation failed"
@@ -343,4 +344,4 @@ ERR_EXP_EDIT_PSQL_CONF="Error: failed editing %s" % basedefs.FILE_PSQL_CONF
 ERR_EXP_FAILED_LIMITS="Error: Could not edit %s" % basedefs.FILE_LIMITS_CONF
 
 ERR_EXP_FAILED_KERNEL_PARAMS="Error: failed setting the kernel parameters"
-ERR_CLEAR_DB_CONNECTIONS = "Error: failed to clear all DB connections"
+ERR_CLEAR_DB_CONNECTIONS = "Error: failed to clear all DB connections"

post_upgrade.py

@@ -0,0 +1,32 @@
+#!/usr/bin/python
+
+# RHEV Manager post upgrade scripts
+# Imported dynamically from rhevm-upgrade
+
+#TODO: Implement all
+
+import common_utils as utils
+import logging
+import traceback
+
+MSG_ERR_UPDATE_PRODUCT_VERSION="Error updating product version"
+
+def updateProductVersion():
+    """
+    Update product version in vdc options
+    table from rpm version
+    """
+    try:
+        # Get rpm version
+        rpmVersion = utils.getRpmVersion('ovirt-engine')
+
+        # Update new version in vdc_option
+        utils.updateVDCOption("ProductRPMVersion", rpmVersion)
+
+    except:
+        logging.error(traceback.format_exc())
+        logging.error(MSG_ERR_UPDATE_PRODUCT_VERSION)
+
+def run():
+    # Update product version in db from rpm version
+    updateProductVersion()