From 9bfd5b848293d9bbc5d73f2319416f3793c80303 Mon Sep 17 00:00:00 2001
From: Joel Capitao <jcapitao@redhat.com>
Date: Thu, 3 Feb 2022 16:28:49 +0100
Subject: [PATCH] Ignore facter error when fetching repo

Even though a repo is set with skip_if_unavailable=True,
Facter logs "Error:..." and then "Ignoring repositories...".
We need to add this regexp to ignored list.

Note: if repo should not be skipped if unavailable, dnf
would have raised error before Facter run.

Change-Id: Id2a3c27d8afb4a1d0e852a70e5a9ccd07e485399
---
 packstack/modules/puppet.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packstack/modules/puppet.py b/packstack/modules/puppet.py
index 22b4aacbd..921b962b6 100644
--- a/packstack/modules/puppet.py
+++ b/packstack/modules/puppet.py
@@ -43,7 +43,10 @@ re_ignore = re.compile(
     'yum.*?install swift-plugin-s3|'
     # facter gives a weird NM error when it's disabled, due to
     # https://tickets.puppetlabs.com/browse/FACT-697
-    'NetworkManager is not running'
+    'NetworkManager is not running|'
+    # facter logs Error even though the repository is set to be skipped
+    # if unavailable
+    'Failed to download metadata for repo'
 )
 re_notice = re.compile(r'notice: .*Notify\[packstack_info\]'
                        r'\/message: defined \'message\' as '