x
/
packstack
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 16312 \u003c16312@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16312\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16312\u003e replied on the change"}
This commit is contained in:
Gerrit User 16312 2022-08-17 13:55:25 +00:00 committed by Gerrit Code Review
parent 4f7c15361e
commit b994d15c92
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fa63bb8d02191b7abefdbaa5c972ef666ef567d9
View File

@ -16,6 +16,24 @@
"message": "WIP until I check whether we should replace hiera_undef as well.",
"revId": "fa63bb8d02191b7abefdbaa5c972ef666ef567d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b4faf8d9_4d55348b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 16312
},
"writtenOn": "2022-08-17T13:55:25Z",
"side": 1,
"message": "hiera_undef comes from https://github.com/redhat-openstack/packstack/blob/eabad465d8656c57a8af0f2612fc1f6cac618cfd/packstack/puppet/modules/packstack/lib/puppet/parser/functions/hiera_undef.rb which uses lookup under the hood so i\u0027d say it should be fine?",
"parentUuid": "4e0baa19_b6a22d81",
"revId": "fa63bb8d02191b7abefdbaa5c972ef666ef567d9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}