x/packstack
Code Issues Proposed changes

Use assertTrue/False instead of assertEqual(T/F)

Browse Source 
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: If529ff10983ec1e6bfbd06e643c2e2e3aaa653fe
Closes-Bug:#1512207
This commit is contained in:
Swapnil Kulkarni (coolsvap)
2016-01-07 12:29:56 +05:30
parent 28e74215ad
commit e1e32285e4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/installer/test_processors.py
View File

@@ -32,7 +32,7 @@ class ProcessorsTestCase(PackstackTestCaseMixin, TestCase):
"""Test packstack.installer.processors.process_ssh_key.""" """Test packstack.installer.processors.process_ssh_key."""
path = process_ssh_key(os.path.join(self.tempdir, 'id_rsa'), 'SSH_KEY') path = process_ssh_key(os.path.join(self.tempdir, 'id_rsa'), 'SSH_KEY')
# test if key was created # test if key was created
self.assertEqual(True, bool(path)) self.assertTrue(bool(path))
# test if key exists # test if key exists
# XXX: process_ssh_key does not create ssh key during test run # XXX: process_ssh_key does not create ssh key during test run
# ... not sure why, nevertheless it works in normal run # ... not sure why, nevertheless it works in normal run