Cleaned packstack.installer.common_utils

- cleaned from useless functions
- refactored to be pep8 compliant
- separated to standalone modules
- added unit tests

Change-Id: If5a300fe04efab9e13549f2b4d05c1b28e2e40c6
This commit is contained in:
Martin Magr
2013-03-01 18:30:07 +01:00
parent 7ef0830ae7
commit eba1d3d5d2
31 changed files with 453 additions and 537 deletions

View File

@@ -12,7 +12,7 @@ import tempfile
import traceback
import basedefs
import common_utils as utils
from . import utils
from .setup_controller import Controller
from .exceptions import ParamValidationError
@@ -175,8 +175,8 @@ def validate_ping(param, options=None):
# TO-DO: to be more flexible, remove this and exit in case param is empty
validate_not_empty(param)
cmd = ["/bin/ping", "-c", "1", str(param)]
out, rc = utils.execCmd(cmdList=cmd)
rc, out = utils.execute(['/bin/ping', '-c', '1', str(param)],
can_fail=True)
if rc != 0:
logging.debug('validate_ping(%s, options=%s) failed.' %
(param, options))