x/poppy
Code Issues Proposed changes

Exposing the failure message to the user

Browse Source 
Closes-Bug: 1400527
Change-Id: I18d7de4014912e9fbd1f82fb620d66e402d83b43
This commit is contained in:
amitgandhinz
2014-12-15 16:54:19 -05:00
parent 92ab98ba65
commit 532f3fc7d1
13 changed files with 105 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
poppy/manager/default/service_async_workers/create_service_worker.py
View File

@@ -37,21 +37,31 @@ def service_create_worker(providers_list, service_controller,
for responder in responders:
for provider_name in responder:
if 'error' in responder[provider_name]:
error_msg = responder[provider_name]['error']
error_info = responder[provider_name]['error_detail']
provider_details_dict[provider_name] = (
provider_details.ProviderDetail(error_info=error_info))
provider_details_dict[provider_name].status = 'failed'
provider_details.ProviderDetail(
error_info=error_info,
status='failed',
error_message=error_msg))
elif 'error' in dns_responder[provider_name]:
error_msg = responder[provider_name]['error']
error_info = dns_responder[provider_name]['error_detail']
provider_details_dict[provider_name] = (
provider_details.ProviderDetail(error_info=error_info))
provider_details_dict[provider_name].status = 'failed'
provider_details.ProviderDetail(
error_info=error_info,
status='failed',
error_message=error_msg))
else:
access_urls = dns_responder[provider_name]['access_urls']
provider_details_dict[provider_name] = (
provider_details.ProviderDetail(
provider_service_id=responder[provider_name]['id'],
access_urls=access_urls))
if 'status' in responder[provider_name]:
provider_details_dict[provider_name].status = (
responder[provider_name]['status'])

2
poppy/manager/default/service_async_workers/delete_service_worker.py
View File

@@ -49,7 +49,7 @@ def service_delete_worker(provider_details, service_controller,
responder[provider_name].get('error_info'))
elif 'error' in dns_responder[provider_name]:
LOG.info('Delete service from DNS failed')
LOG.info('Updating provider detail status of %s for %s'.foramt(
LOG.info('Updating provider detail status of %s for %s'.format(
(provider_name, service_name)))
# stores the error info for debugging purposes.
provider_details[provider_name].error_info = (

3
poppy/manager/default/service_async_workers/update_service_worker.py
View File

@@ -55,8 +55,9 @@ def update_worker(service_controller, project_id, service_name,
else:
provider_details_dict[provider_name] = (
provider_details.ProviderDetail(
status='failed',
error_message=responder[provider_name]['error'],
error_info=responder[provider_name]['error_detail']))
provider_details_dict[provider_name].status = 'failed'
# update the service object
service_controller.storage_controller.update(project_id, service_name,