x
/
poppy
Code Issues Proposed changes

fix: model helpers defaults 

- check cert_info being None
- check if access_url dict has corresponding domain

Change-Id: I55f20c13429afc4844d4169046d941c5b9ab0691
This commit is contained in:
Sriram Madapusi Vasudevan 2015-10-20 17:06:06 -04:00
parent 352a5f0fe9
commit 7f324eb335
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
poppy/model/helpers/domain.py
View File

@ -125,6 +125,6 @@ class Domain(common.DictSerializableModel):
res = super(Domain, self).to_dict()
# cert info is a temporary property when
# trying to create cert, so skip serialization
if 'cert_info' in res:
if 'cert_info' in res and res['cert_info'] is not None:
res['cert_info'] = res['cert_info'].to_dict()
return res

2
poppy/model/helpers/provider_details.py
View File

@ -156,7 +156,7 @@ class ProviderDetail(common.DictSerializableModel):
:param domain
'''
for access_url in self.access_urls:
if access_url['domain'] == domain:
if access_url.get('domain') == domain:
return access_url
return None