From 21e1ec55ed2bc67b89409f9990bc3e5a780f7fd0 Mon Sep 17 00:00:00 2001 From: Gerrit User 16551 <16551@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 24 Jul 2018 17:17:27 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review-1 (4 comments) Got few nit's to be addressed before this can be merged. Otherwise, looks good to me. Patch-set: 2 Label: Code-Review=-1 --- ce64bc5b5c0006550d77281015b0a5d18a350d7e | 78 ++++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 ce64bc5b5c0006550d77281015b0a5d18a350d7e diff --git a/ce64bc5b5c0006550d77281015b0a5d18a350d7e b/ce64bc5b5c0006550d77281015b0a5d18a350d7e new file mode 100644 index 0000000..91c5240 --- /dev/null +++ b/ce64bc5b5c0006550d77281015b0a5d18a350d7e @@ -0,0 +1,78 @@ +{ + "comments": [ + { + "key": { + "uuid": "5f7c97a3_9388e56b", + "filename": "glance-powervc/powervc/glance/manager/manager.py", + "patchSetId": 2 + }, + "lineNbr": 1336, + "author": { + "id": 16551 + }, + "writtenOn": "2018-07-24T17:17:27Z", + "side": 1, + "message": "Fix the indentation", + "revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "5f7c97a3_3328f134", + "filename": "glance-powervc/powervc/glance/manager/manager.py", + "patchSetId": 2 + }, + "lineNbr": 1692, + "author": { + "id": 16551 + }, + "writtenOn": "2018-07-24T17:17:27Z", + "side": 1, + "message": "Isn\u0027t this already moved to the if/else block above?", + "range": { + "startLine": 1689, + "startChar": 0, + "endLine": 1692, + "endChar": 77 + }, + "revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "5f7c97a3_50256815", + "filename": "glance-powervc/powervc/glance/manager/manager.py", + "patchSetId": 2 + }, + "lineNbr": 2184, + "author": { + "id": 16551 + }, + "writtenOn": "2018-07-24T17:17:27Z", + "side": 1, + "message": "Fix the indendation", + "revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "5f7c97a3_13b5b5ed", + "filename": "glance-powervc/powervc/glance/manager/manager.py", + "patchSetId": 2 + }, + "lineNbr": 3434, + "author": { + "id": 16551 + }, + "writtenOn": "2018-07-24T17:17:27Z", + "side": 1, + "message": "Fix the indentation. Also, I think this if/else block can be simplified if you get the pvc_image value in the previous check and use it here.", + "revId": "ce64bc5b5c0006550d77281015b0a5d18a350d7e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file