x
/
proliantutils
Code Issues Proposed changes

Removes filter on the bios settings. 

This fix changes the default behavior to consider all the BIOS settings
rather than applying filter on them for only specific settings.

Change-Id: I19dc807c41a52136e8f7c306004508885af2733d
This commit is contained in:
vmud213 2019-07-31 17:01:02 +00:00
parent eff34b56d8
commit a03de4f619
4 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
proliantutils/ilo/client.py
View File

@ -740,7 +740,7 @@ class IloClient(operations.IloOperations):
"""
return self._call_method('get_host_post_state')
def get_current_bios_settings(self, only_allowed_settings=True):
def get_current_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -757,7 +757,7 @@ class IloClient(operations.IloOperations):
return self._call_method('get_current_bios_settings',
only_allowed_settings)
def get_pending_bios_settings(self, only_allowed_settings=True):
def get_pending_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -774,7 +774,7 @@ class IloClient(operations.IloOperations):
return self._call_method('get_pending_bios_settings',
only_allowed_settings)
def set_bios_settings(self, data=None, only_allowed_settings=True):
def set_bios_settings(self, data=None, only_allowed_settings=False):
"""Sets current BIOS settings to the provided data.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -791,7 +791,7 @@ class IloClient(operations.IloOperations):
return self._call_method('set_bios_settings', data,
only_allowed_settings)
def get_default_bios_settings(self, only_allowed_settings=True):
def get_default_bios_settings(self, only_allowed_settings=False):
"""Get default BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings

8
proliantutils/ilo/operations.py
View File

@ -382,7 +382,7 @@ class IloOperations(object):
"""
raise exception.IloCommandNotSupportedError(ERRMSG)
def get_current_bios_settings(self, only_allowed_settings=True):
def get_current_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -398,7 +398,7 @@ class IloOperations(object):
"""
raise exception.IloCommandNotSupportedError(ERRMSG)
def get_pending_bios_settings(self, only_allowed_settings=True):
def get_pending_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -414,7 +414,7 @@ class IloOperations(object):
"""
raise exception.IloCommandNotSupportedError(ERRMSG)
def set_bios_settings(self, data=None, only_allowed_settings=True):
def set_bios_settings(self, data=None, only_allowed_settings=False):
"""Sets current BIOS settings to the provided data.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -430,7 +430,7 @@ class IloOperations(object):
"""
raise exception.IloCommandNotSupportedError(ERRMSG)
def get_default_bios_settings(self, only_allowed_settings=True):
def get_default_bios_settings(self, only_allowed_settings=False):
"""Get default BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings

8
proliantutils/ilo/ris.py
View File

@ -1853,7 +1853,7 @@ class RISOperations(rest.RestConnectorBase, operations.IloOperations):
raise exception.IloError("Attribute 'Oem/Hp/PostState' "
"not found on system.")
def get_current_bios_settings(self, only_allowed_settings=True):
def get_current_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -1875,7 +1875,7 @@ class RISOperations(rest.RestConnectorBase, operations.IloOperations):
bios_settings, constants.SUPPORTED_BIOS_PROPERTIES)
return bios_settings
def get_pending_bios_settings(self, only_allowed_settings=True):
def get_pending_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -1910,7 +1910,7 @@ class RISOperations(rest.RestConnectorBase, operations.IloOperations):
config, constants.SUPPORTED_BIOS_PROPERTIES)
return config
def set_bios_settings(self, data=None, only_allowed_settings=True):
def set_bios_settings(self, data=None, only_allowed_settings=False):
"""Sets current BIOS settings to the provided data.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -1941,7 +1941,7 @@ class RISOperations(rest.RestConnectorBase, operations.IloOperations):
self._change_bios_setting(data)
def get_default_bios_settings(self, only_allowed_settings=True):
def get_default_bios_settings(self, only_allowed_settings=False):
"""Get default BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings

8
proliantutils/redfish/redfish.py
View File

@ -1095,7 +1095,7 @@ class RedfishOperations(operations.IloOperations):
sushy_system = self._get_sushy_system(PROLIANT_SYSTEM_ID)
return sushy_system.has_disk_erase_completed()
def get_current_bios_settings(self, only_allowed_settings=True):
def get_current_bios_settings(self, only_allowed_settings=False):
"""Get current BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -1123,7 +1123,7 @@ class RedfishOperations(operations.IloOperations):
attributes, ilo_cons.SUPPORTED_REDFISH_BIOS_PROPERTIES)
return attributes
def get_pending_bios_settings(self, only_allowed_settings=True):
def get_pending_bios_settings(self, only_allowed_settings=False):
"""Get pending BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings are
@ -1151,7 +1151,7 @@ class RedfishOperations(operations.IloOperations):
attributes, ilo_cons.SUPPORTED_REDFISH_BIOS_PROPERTIES)
return attributes
def set_bios_settings(self, data=None, only_allowed_settings=True):
def set_bios_settings(self, data=None, only_allowed_settings=False):
"""Sets current BIOS settings to the provided data.
:param: only_allowed_settings: True when only allowed BIOS settings
@ -1190,7 +1190,7 @@ class RedfishOperations(operations.IloOperations):
LOG.debug(msg)
raise exception.IloError(msg)
def get_default_bios_settings(self, only_allowed_settings=True):
def get_default_bios_settings(self, only_allowed_settings=False):
"""Get default BIOS settings.
:param: only_allowed_settings: True when only allowed BIOS settings