All modules confirm with this now except for
the puppet-tripleo module which has some
customizations that I didn't want to override. [1]
Since puppet-tripleo doesn't support ubuntu I didn't
push the nodepool-bionic beaker file to that repo either.
[1] http://paste.openstack.org/show/726199/
Change-Id: I5e51f683047dbbf7a5f1fc5e200f40e5110e499e
Pin modulesync to <0.8.0 and update the managed modules list
Change-Id: Id7d1202cf218adf5c33743259953e57022cba723
Depends-On: Iee22a969ea4395f3784cceef5300cc124d50bfd5
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636
Change-Id: Id8a2ab10329c05af5b766e2a441a744ced073671
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests. With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.
Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.
Change-Id: I561ea844c05481a804975e77ff5f45002449f9a5
- Why? because we disable a check which has been deleted for a
while from puppet-lint code!
Change-Id: I0a01bc41ef15d0312520cfaf71cb704843cbe824
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
* install r10k gem
* add openstack/ to .gitignore
* Update Rakefile to not use fixtures anymore
See https://review.openstack.org/#/c/226830/ for background.
Change-Id: I4513491b4f53c74acd433c0045c5f3c956bc06ce
This commit modifies our default config to include rspec-puppet 2.2.0
from 2.1.0. This is to address the issue with helper code not being
loaded properly, fixed by
d4278834d5.
Change-Id: I1ef9a7c55aff05fb94da16884d04e922d2c99486
Add default config for Gemfile, puppet-lint disabled checks,
nodepool files for centos7 and trusty, and a sample
modulesync.yaml for configuring msync.
Co-Authored-By: Cody Herries <cody@puppetlabs.com>
Change-Id: Ib00a5b3b9c62f063b0b88b2d883e0ebad6506840