All modules confirm with this now except for
the puppet-tripleo module which has some
customizations that I didn't want to override. 
Since puppet-tripleo doesn't support ubuntu I didn't
push the nodepool-bionic beaker file to that repo either.
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests. With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.
Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.
* install r10k gem
* add openstack/ to .gitignore
* Update Rakefile to not use fixtures anymore
See https://review.openstack.org/#/c/226830/ for background.
This commit modifies our default config to include rspec-puppet 2.2.0
from 2.1.0. This is to address the issue with helper code not being
loaded properly, fixed by
Add default config for Gemfile, puppet-lint disabled checks,
nodepool files for centos7 and trusty, and a sample
modulesync.yaml for configuring msync.
Co-Authored-By: Cody Herries <firstname.lastname@example.org>