x/python-almanachclient
Code Issues Proposed changes

Fix wrong arguments to update instance entity

Browse Source 
Change-Id: I29b80847fedb0b663ad1ed17996a0396a9cf7d07
This commit is contained in:
Frédéric Guillot
2017-05-31 17:26:27 -04:00
parent d5375664d9
commit 24c953399d
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
almanachclient/commands/update_instance_entity.py
View File

@@ -39,10 +39,10 @@ class UpdateInstanceEntityCommand(ShowOne):
params = dict() params = dict()
if parsed_args.start: if parsed_args.start:
params['start'] = parser.parse(parsed_args.start) params['start_date'] = parser.parse(parsed_args.start)
if parsed_args.end: if parsed_args.end:
params['end'] = parser.parse(parsed_args.end) params['end_date'] = parser.parse(parsed_args.end)
if parsed_args.flavor: if parsed_args.flavor:
params['flavor'] = parsed_args.flavor params['flavor'] = parsed_args.flavor

2
almanachclient/tests/commands/test_update_instance_entity.py
View File

@@ -52,4 +52,4 @@ class TestUpdateInstanceEntityCommand(base.TestCase):
self.assertEqual(expected, self.command.take_action(self.args)) self.assertEqual(expected, self.command.take_action(self.args))
self.client.update_instance_entity.assert_called_once_with(self.args.instance_id, self.client.update_instance_entity.assert_called_once_with(self.args.instance_id,
start=datetime.datetime(2017, 1, 1, 0, 0)) start_date=datetime.datetime(2017, 1, 1, 0, 0))

6
almanachclient/v1/client.py
View File

@@ -270,8 +270,8 @@ class Client(HttpClient):
"""Update an instance entity. """Update an instance entity.
:arg str instance_id: Instance UUID :arg str instance_id: Instance UUID
:arg datetime start: Start date :arg datetime start_date: Start date
:arg datetime end: End date :arg datetime end_date: End date
:arg str flavor: The flavor :arg str flavor: The flavor
:arg str name: The instance name :arg str name: The instance name
:raises: ClientError :raises: ClientError
@@ -279,7 +279,7 @@ class Client(HttpClient):
""" """
url = '{}/{}/entity/instance/{}'.format(self.url, self.api_version, instance_id) url = '{}/{}/entity/instance/{}'.format(self.url, self.api_version, instance_id)
for param in ['start', 'end']: for param in ['start_date', 'end_date']:
if param in kwargs: if param in kwargs:
kwargs[param] = self._format_body_datetime(kwargs[param]) kwargs[param] = self._format_body_datetime(kwargs[param])