Add a bunch of TODO's to the API implementation.
This commit is contained in:
@@ -305,6 +305,18 @@ class CloudController(object):
|
||||
|
||||
return True
|
||||
|
||||
# TODO(soren): Lots and lots of input validation. We're accepting
|
||||
# strings here (such as ipProtocol), which is put into
|
||||
# filter rules verbatim.
|
||||
# TODO(soren): Dupe detection. Adding the same rule twice actually
|
||||
# adds the same rule twice to the rule set, which is
|
||||
# pointless.
|
||||
# TODO(soren): This has only been tested with Boto as the client.
|
||||
# Unfortunately, it seems Boto is using an old API
|
||||
# for these operations, so support for newer API versions
|
||||
# is sketchy.
|
||||
# TODO(soren): De-duplicate the turning method arguments into dict stuff.
|
||||
# revoke_security_group_ingress uses the exact same logic.
|
||||
@rbac.allow('netadmin')
|
||||
def authorize_security_group_ingress(self, context, group_name,
|
||||
to_port=None, from_port=None,
|
||||
|
Reference in New Issue
Block a user