x/python-ganttclient
Code Issues Proposed changes

HACKING fixes, TODO authors.

Browse Source 
Looks like this fixes all HACKING problems that were around.
Thanks to Dina Belova and Alexander Kovalev for this work.

Change-Id: I63ae1ab2f1bb37daa236cde4096c3c893fd80dd2
This commit is contained in:
Yuriy Taraday
2012-03-06 12:47:47 +04:00
parent ca2d92adca
commit 15087b4246
5 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bin/nova-manage
View File

@@ -1746,7 +1746,7 @@ class StorageManagerCommands(object):
flav['description']) flav['description'])
def flavor_create(self, label, desc): def flavor_create(self, label, desc):
# TODO flavor name must be unique # TODO(renukaapte) flavor name must be unique
try: try:
db.sm_flavor_create(context.get_admin_context(), db.sm_flavor_create(context.get_admin_context(),
dict(label=label, dict(label=label,
@@ -1792,7 +1792,7 @@ class StorageManagerCommands(object):
b['config_params'],) b['config_params'],)
def backend_add(self, flavor_label, sr_type, *args): def backend_add(self, flavor_label, sr_type, *args):
# TODO Add backend_introduce. # TODO(renukaapte) Add backend_introduce.
ctxt = context.get_admin_context() ctxt = context.get_admin_context()
params = dict(map(self._splitfun, args)) params = dict(map(self._splitfun, args))
sr_uuid = utils.gen_uuid() sr_uuid = utils.gen_uuid()

2
nova/tests/baremetal/test_proxy_bare_metal.py
View File

@@ -261,7 +261,7 @@ class ProxyBareMetalTestCase(test.TestCase):
# Code under test # Code under test
conn = proxy.get_connection(True) conn = proxy.get_connection(True)
# TODO: this is not a very good fake instance # TODO(mikalstill): this is not a very good fake instance
info = conn.get_info({'name': 'instance-00000001'}) info = conn.get_info({'name': 'instance-00000001'})
# Expected values # Expected values

3
nova/tests/rpc/common.py
View File

@@ -132,7 +132,8 @@ class BaseRpcTestCase(test.TestCase):
"""Calls echo in the passed queue""" """Calls echo in the passed queue"""
LOG.debug(_("Nested received %(queue)s, %(value)s") LOG.debug(_("Nested received %(queue)s, %(value)s")
% locals()) % locals())
# TODO: so, it will replay the context and use the same REQID? # TODO(comstud):
# so, it will replay the context and use the same REQID?
# that's bizarre. # that's bizarre.
ret = self.rpc.call(context, ret = self.rpc.call(context,
queue, queue,

2
nova/tests/test_auth.py
View File

@@ -420,5 +420,5 @@ class AuthManagerDbTestCase(_AuthManagerBaseTestCase):
if __name__ == "__main__": if __name__ == "__main__":
# TODO: Implement use_fake as an option # TODO(anotherjesse): Implement use_fake as an option
unittest.main() unittest.main()

7
nova/vsa/api.py
View File

@@ -295,7 +295,8 @@ class API(base.Base):
vc_count = kwargs.get('vc_count', None) vc_count = kwargs.get('vc_count', None)
if vc_count is not None: if vc_count is not None:
# VP-TODO: This request may want to update number of VCs # VP-TODO(vladimir.p):
# This request may want to update number of VCs
# Get number of current VCs and add/delete VCs appropriately # Get number of current VCs and add/delete VCs appropriately
vsa = self.get(context, vsa_id) vsa = self.get(context, vsa_id)
vc_count = int(vc_count) vc_count = int(vc_count)
@@ -317,13 +318,13 @@ class API(base.Base):
add_cnt = vc_count - old_vc_count add_cnt = vc_count - old_vc_count
LOG.debug(_("Adding %(add_cnt)s VCs to VSA %(vsa_name)s."), LOG.debug(_("Adding %(add_cnt)s VCs to VSA %(vsa_name)s."),
locals()) locals())
# VP-TODO: actual code for adding new VCs # VP-TODO(vladimir.p): actual code for adding new VCs
elif vc_count < old_vc_count: elif vc_count < old_vc_count:
del_cnt = old_vc_count - vc_count del_cnt = old_vc_count - vc_count
LOG.debug(_("Deleting %(del_cnt)s VCs from VSA %(vsa_name)s."), LOG.debug(_("Deleting %(del_cnt)s VCs from VSA %(vsa_name)s."),
locals()) locals())
# VP-TODO: actual code for deleting extra VCs # VP-TODO(vladimir.p): actual code for deleting extra VCs
def _force_volume_delete(self, ctxt, volume): def _force_volume_delete(self, ctxt, volume):
"""Delete a volume, bypassing the check that it must be available.""" """Delete a volume, bypassing the check that it must be available."""