x/python-ganttclient
Code Issues Proposed changes

Remove unnecessary setUp() and tearDown() methods

Browse Source 
It's unnecessary to implement setUp() and tearDown() when they only call
the parent class method of the same name.

Change-Id: I8a2c7f50e17def87ada8d4f1c1b554eb916afbd1
This commit is contained in:
Johannes Erdfelt
2013-03-06 23:58:59 +00:00
parent f879d0af1e
commit 1eb1de3513
3 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
nova/tests/test_libvirt.py
View File

@@ -171,9 +171,6 @@ class CacheConcurrencyTestCase(test.TestCase):
'nova.virt.libvirt.imagebackend.libvirt_utils', 'nova.virt.libvirt.imagebackend.libvirt_utils',
fake_libvirt_utils)) fake_libvirt_utils))
def tearDown(self):
super(CacheConcurrencyTestCase, self).tearDown()
def test_same_fname_concurrency(self): def test_same_fname_concurrency(self):
# Ensures that the same fname cache runs at a sequentially. # Ensures that the same fname cache runs at a sequentially.
uuid = uuidutils.generate_uuid() uuid = uuidutils.generate_uuid()

4
nova/tests/test_virt_disk_vfs_localfs.py
View File

@@ -148,10 +148,6 @@ class VirtDiskVFSLocalFSTestPaths(test.TestCase):
class VirtDiskVFSLocalFSTest(test.TestCase): class VirtDiskVFSLocalFSTest(test.TestCase):
def setUp(self):
super(VirtDiskVFSLocalFSTest, self).setUp()
def test_makepath(self): def test_makepath(self):
global dirs, commands global dirs, commands
dirs = [] dirs = []

3
nova/tests/test_virt_drivers.py
View File

@@ -192,9 +192,6 @@ class _VirtDriverTestCase(_FakeDriverBackendTestCase):
self.ctxt = test_utils.get_test_admin_context() self.ctxt = test_utils.get_test_admin_context()
self.image_service = fake_image.FakeImageService() self.image_service = fake_image.FakeImageService()
def tearDown(self):
super(_VirtDriverTestCase, self).tearDown()
def _get_running_instance(self): def _get_running_instance(self):
instance_ref = test_utils.get_test_instance() instance_ref = test_utils.get_test_instance()
network_info = test_utils.get_test_network_info() network_info = test_utils.get_test_network_info()