diff --git a/nova/flags.py b/nova/flags.py index 25a3e013..58c37f93 100644 --- a/nova/flags.py +++ b/nova/flags.py @@ -351,7 +351,7 @@ DEFINE_string('lock_path', os.path.join(os.path.dirname(__file__), '../'), 'Directory for lock files') DEFINE_string('logdir', None, 'output to a per-service log file in named ' 'directory') -DEFINE_integer('logfile_mode', 0644, 'Default file mode of the logs.') +DEFINE_string('logfile_mode', '0644', 'Default file mode of the logs.') DEFINE_string('sqlite_db', 'nova.sqlite', 'file name for sqlite') DEFINE_string('sql_connection', 'sqlite:///$state_path/$sqlite_db', diff --git a/nova/log.py b/nova/log.py index eb0b6020..1e04f755 100644 --- a/nova/log.py +++ b/nova/log.py @@ -259,9 +259,10 @@ class NovaRootLogger(NovaLogger): self.addHandler(self.filelog) self.logpath = logpath + mode = int(FLAGS.logfile_mode, 8) st = os.stat(self.logpath) - if st.st_mode != (stat.S_IFREG | FLAGS.logfile_mode): - os.chmod(self.logpath, FLAGS.logfile_mode) + if st.st_mode != (stat.S_IFREG | mode): + os.chmod(self.logpath, mode) else: self.removeHandler(self.filelog) self.addHandler(self.streamlog)