x/python-ganttclient
Code Issues Proposed changes

Merge "Improve performance of safe_log()."

Browse Source
This commit is contained in:
Jenkins
2012-03-26 19:54:20 +00:00
committed by Gerrit Code Review
parent eacebad570 30002a4de7
commit 40b5e83117
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
nova/rpc/common.py
View File

@@ -127,7 +127,12 @@ class Connection(object):
def _safe_log(log_func, msg, msg_data): def _safe_log(log_func, msg, msg_data):
"""Sanitizes the msg_data field before logging.""" """Sanitizes the msg_data field before logging."""
has_method = 'method' in msg_data SANITIZE = {
'set_admin_password': ('new_pass',),
'run_instance': ('admin_password',),
}
has_method = 'method' in msg_data and msg_data['method'] in SANITIZE
has_context_token = '_context_auth_token' in msg_data has_context_token = '_context_auth_token' in msg_data
has_token = 'auth_token' in msg_data has_token = 'auth_token' in msg_data
@@ -137,10 +142,6 @@ def _safe_log(log_func, msg, msg_data):
msg_data = copy.deepcopy(msg_data) msg_data = copy.deepcopy(msg_data)
if has_method: if has_method:
SANITIZE = {
'set_admin_password': ('new_pass',),
'run_instance': ('admin_password',),
}
method = msg_data['method'] method = msg_data['method']
if method in SANITIZE: if method in SANITIZE:
args_to_sanitize = SANITIZE[method] args_to_sanitize = SANITIZE[method]