x/python-ganttclient
Code Issues Proposed changes

Don't use _ for variable name

Browse Source 
_ is reserved for gettext use and using _ for variable names can result
in runtime failures when trying to lookup string translations

Change-Id: I8835142fd19ba5f395ddef959c38167f4144b813
This commit is contained in:
Johannes Erdfelt
2012-03-07 04:25:19 +00:00
parent 090843df20
commit 6f50d772c1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nova/tests/test_misc.py
View File

@@ -147,7 +147,7 @@ class LockTestCase(test.TestCase):
self.assertEquals(e.errno, errno.EPIPE) self.assertEquals(e.errno, errno.EPIPE)
return return
rfds, _, __ = select.select([rpipe], [], [], 1) rfds, _wfds, _efds = select.select([rpipe], [], [], 1)
self.assertEquals(len(rfds), 0, "The other process, which was" self.assertEquals(len(rfds), 0, "The other process, which was"
" supposed to be locked, " " supposed to be locked, "
"wrote on its end of the " "wrote on its end of the "