From 93caa353cd83e653f93e5ff5d430116dc1a5db65 Mon Sep 17 00:00:00 2001 From: Jesse Andrews Date: Thu, 15 Jul 2010 11:07:40 -0500 Subject: [PATCH] remove import of vendor since we have PPA now --- HACKING | 3 --- bin/nova-api | 2 +- bin/nova-compute | 2 +- bin/nova-instancemonitor | 2 +- bin/nova-objectstore | 2 +- bin/nova-rsapi | 2 +- bin/nova-volume | 2 +- docs/conf.py | 2 +- nova/adminclient.py | 2 +- nova/datastore.py | 2 +- nova/endpoint/api.py | 2 +- nova/endpoint/cloud.py | 2 +- nova/endpoint/images.py | 2 +- nova/endpoint/rackspace.py | 2 +- nova/flags.py | 2 +- nova/process.py | 2 +- nova/rpc.py | 2 +- nova/server.py | 2 +- nova/tests/api_unittest.py | 2 +- nova/tests/cloud_unittest.py | 2 +- nova/tests/future_unittest.py | 2 +- nova/tests/model_unittest.py | 2 +- nova/tests/network_unittest.py | 2 +- nova/tests/node_unittest.py | 2 +- nova/tests/objectstore_unittest.py | 2 +- nova/tests/process_unittest.py | 2 +- nova/tests/users_unittest.py | 2 +- nova/tests/validator_unittest.py | 2 +- nova/twistd.py | 2 +- nova/vendor.py | 24 ------------------------ run_tests.py | 2 +- 31 files changed, 29 insertions(+), 56 deletions(-) delete mode 100644 nova/vendor.py diff --git a/HACKING b/HACKING index 77e42b8e..325ae919 100644 --- a/HACKING +++ b/HACKING @@ -10,15 +10,12 @@ Imports - thou shalt not import objects, only modules - thou shalt not import more than one module per line - thou shalt not make relative imports -- thou shalt "from nova import vendor" before importing third party code - thou shalt organize your imports according to the following template :: # vim: tabstop=4 shiftwidth=4 softtabstop=4 {{stdlib imports in human alphabetical order}} \n - from nova import vendor - {{vendor imports in human alphabetical order}} \n {{nova imports in human alphabetical order}} \n diff --git a/bin/nova-api b/bin/nova-api index 7bc9166b..ae274abf 100755 --- a/bin/nova-api +++ b/bin/nova-api @@ -23,7 +23,7 @@ Tornado daemon for the main API endpoint. import logging -from nova import vendor + from tornado import httpserver from tornado import ioloop diff --git a/bin/nova-compute b/bin/nova-compute index 80388703..5635efba 100755 --- a/bin/nova-compute +++ b/bin/nova-compute @@ -33,7 +33,7 @@ NOVA_PATH = os.path.join(os.path.dirname(os.path.dirname(__file__)), 'nova') if os.path.exists(NOVA_PATH): sys.path.insert(0, os.path.dirname(NOVA_PATH)) -from nova import vendor + from carrot import connection from carrot import messaging from twisted.internet import task diff --git a/bin/nova-instancemonitor b/bin/nova-instancemonitor index d3f0ae22..d2ed82c9 100755 --- a/bin/nova-instancemonitor +++ b/bin/nova-instancemonitor @@ -23,7 +23,7 @@ import logging -from nova import vendor + from twisted.internet import task from twisted.application import service diff --git a/bin/nova-objectstore b/bin/nova-objectstore index 7876864c..8ae80707 100755 --- a/bin/nova-objectstore +++ b/bin/nova-objectstore @@ -23,7 +23,7 @@ import logging -from nova import vendor + from tornado import httpserver from tornado import ioloop diff --git a/bin/nova-rsapi b/bin/nova-rsapi index c2f2c9d7..cca5b304 100755 --- a/bin/nova-rsapi +++ b/bin/nova-rsapi @@ -23,7 +23,7 @@ import logging from wsgiref import simple_server -from nova import vendor + from tornado import ioloop from nova import flags diff --git a/bin/nova-volume b/bin/nova-volume index 9b7787c9..8296eb1d 100755 --- a/bin/nova-volume +++ b/bin/nova-volume @@ -23,7 +23,7 @@ import logging -from nova import vendor + from tornado import ioloop from nova import flags diff --git a/docs/conf.py b/docs/conf.py index 784d8c09..fb3fd1a3 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -18,7 +18,7 @@ import sys, os # documentation root, use os.path.abspath to make it absolute, like shown here. sys.path.append(os.path.abspath('/Users/jmckenty/Projects/cc')) sys.path.append([os.path.abspath('../nova'),os.path.abspath('../'),os.path.abspath('../vendor')]) -from nova import vendor + # -- General configuration ----------------------------------------------------- diff --git a/nova/adminclient.py b/nova/adminclient.py index 1a5f4141..42297faf 100644 --- a/nova/adminclient.py +++ b/nova/adminclient.py @@ -21,7 +21,7 @@ Nova User API client library. import base64 -from nova import vendor + import boto from boto.ec2.regioninfo import RegionInfo diff --git a/nova/datastore.py b/nova/datastore.py index 8d6272ad..ab6da704 100644 --- a/nova/datastore.py +++ b/nova/datastore.py @@ -25,7 +25,7 @@ before trying to run this. import logging -from nova import vendor + import redis from nova import exception diff --git a/nova/endpoint/api.py b/nova/endpoint/api.py index 25551919..2046d01a 100755 --- a/nova/endpoint/api.py +++ b/nova/endpoint/api.py @@ -29,7 +29,7 @@ import urllib # TODO(termie): replace minidom with etree from xml.dom import minidom -from nova import vendor + import tornado.web from twisted.internet import defer diff --git a/nova/endpoint/cloud.py b/nova/endpoint/cloud.py index 5b713feb..97f31349 100644 --- a/nova/endpoint/cloud.py +++ b/nova/endpoint/cloud.py @@ -28,7 +28,7 @@ import logging import os import time -from nova import vendor + from twisted.internet import defer from nova import datastore diff --git a/nova/endpoint/images.py b/nova/endpoint/images.py index 5c651473..34da907c 100644 --- a/nova/endpoint/images.py +++ b/nova/endpoint/images.py @@ -25,7 +25,7 @@ import json import random import urllib -from nova import vendor + import boto import boto.s3 diff --git a/nova/endpoint/rackspace.py b/nova/endpoint/rackspace.py index 29a077b2..18cb201a 100644 --- a/nova/endpoint/rackspace.py +++ b/nova/endpoint/rackspace.py @@ -27,7 +27,7 @@ import multiprocessing import os import time -from nova import vendor + import tornado.web from twisted.internet import defer diff --git a/nova/flags.py b/nova/flags.py index 22e00a44..60245a34 100644 --- a/nova/flags.py +++ b/nova/flags.py @@ -23,7 +23,7 @@ where they're used. import socket -from nova import vendor + from gflags import * # This keeps pylint from barfing on the imports diff --git a/nova/process.py b/nova/process.py index 00ec4a26..4c1cef58 100644 --- a/nova/process.py +++ b/nova/process.py @@ -24,7 +24,7 @@ import logging import multiprocessing import StringIO -from nova import vendor + from twisted.internet import defer from twisted.internet import error from twisted.internet import process diff --git a/nova/rpc.py b/nova/rpc.py index 72a84b7f..1b171f5d 100644 --- a/nova/rpc.py +++ b/nova/rpc.py @@ -26,7 +26,7 @@ import logging import sys import uuid -from nova import vendor + from carrot import connection from carrot import messaging from twisted.internet import defer diff --git a/nova/server.py b/nova/server.py index 1a6f3387..8f4ea91a 100644 --- a/nova/server.py +++ b/nova/server.py @@ -27,7 +27,7 @@ import signal import sys import time -from nova import vendor + import daemon from daemon import pidlockfile diff --git a/nova/tests/api_unittest.py b/nova/tests/api_unittest.py index aee57b51..2937ef0b 100644 --- a/nova/tests/api_unittest.py +++ b/nova/tests/api_unittest.py @@ -20,7 +20,7 @@ import httplib import random import StringIO -from nova import vendor + import boto from boto.ec2 import regioninfo from tornado import httpserver diff --git a/nova/tests/cloud_unittest.py b/nova/tests/cloud_unittest.py index 9df83ec6..6bafe2ea 100644 --- a/nova/tests/cloud_unittest.py +++ b/nova/tests/cloud_unittest.py @@ -22,7 +22,7 @@ import time import unittest from xml.etree import ElementTree -from nova import vendor + from tornado import ioloop from twisted.internet import defer diff --git a/nova/tests/future_unittest.py b/nova/tests/future_unittest.py index be4218c3..a4523a31 100644 --- a/nova/tests/future_unittest.py +++ b/nova/tests/future_unittest.py @@ -22,7 +22,7 @@ import time import unittest from xml.etree import ElementTree -from nova import vendor + import mox from tornado import ioloop from twisted.internet import defer diff --git a/nova/tests/model_unittest.py b/nova/tests/model_unittest.py index f70cab40..37a4c3e8 100644 --- a/nova/tests/model_unittest.py +++ b/nova/tests/model_unittest.py @@ -19,7 +19,7 @@ import logging import time -from nova import vendor + from twisted.internet import defer from nova import exception diff --git a/nova/tests/network_unittest.py b/nova/tests/network_unittest.py index dd1966ff..af9efffb 100644 --- a/nova/tests/network_unittest.py +++ b/nova/tests/network_unittest.py @@ -20,7 +20,7 @@ import os import logging import unittest -from nova import vendor + import IPy from nova import flags diff --git a/nova/tests/node_unittest.py b/nova/tests/node_unittest.py index 4f7bbd58..60f97741 100644 --- a/nova/tests/node_unittest.py +++ b/nova/tests/node_unittest.py @@ -21,7 +21,7 @@ import time from xml.etree import ElementTree -from nova import vendor + from twisted.internet import defer from nova import exception diff --git a/nova/tests/objectstore_unittest.py b/nova/tests/objectstore_unittest.py index ca2d3115..0c700ff9 100644 --- a/nova/tests/objectstore_unittest.py +++ b/nova/tests/objectstore_unittest.py @@ -23,7 +23,7 @@ import os import shutil import tempfile -from nova import vendor + from nova import flags from nova import objectstore diff --git a/nova/tests/process_unittest.py b/nova/tests/process_unittest.py index 671ab05c..fe625b6c 100644 --- a/nova/tests/process_unittest.py +++ b/nova/tests/process_unittest.py @@ -19,7 +19,7 @@ import logging from xml.etree import ElementTree -from nova import vendor + from twisted.internet import defer from twisted.internet import reactor diff --git a/nova/tests/users_unittest.py b/nova/tests/users_unittest.py index 6110248b..4bc66ca5 100644 --- a/nova/tests/users_unittest.py +++ b/nova/tests/users_unittest.py @@ -19,7 +19,7 @@ import logging import unittest -from nova import vendor + from M2Crypto import BIO from M2Crypto import RSA from M2Crypto import X509 diff --git a/nova/tests/validator_unittest.py b/nova/tests/validator_unittest.py index 38cddfef..fba5b306 100644 --- a/nova/tests/validator_unittest.py +++ b/nova/tests/validator_unittest.py @@ -19,7 +19,7 @@ import logging import unittest -from nova import vendor + from nova import flags from nova import test diff --git a/nova/twistd.py b/nova/twistd.py index 03de2d0a..3d7fdeb6 100644 --- a/nova/twistd.py +++ b/nova/twistd.py @@ -29,7 +29,7 @@ import time import UserDict import logging.handlers -from nova import vendor + from twisted.scripts import twistd from twisted.python import log from twisted.python import reflect diff --git a/nova/vendor.py b/nova/vendor.py deleted file mode 100644 index db75f30e..00000000 --- a/nova/vendor.py +++ /dev/null @@ -1,24 +0,0 @@ -# vim: tabstop=4 shiftwidth=4 softtabstop=4 - -# Copyright 2010 United States Government as represented by the -# Administrator of the National Aeronautics and Space Administration. -# All Rights Reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); you may -# not use this file except in compliance with the License. You may obtain -# a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT -# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the -# License for the specific language governing permissions and limitations -# under the License. - -""" -Get our vendor folders into the system path. -""" - -print 'sorry, we cannot include vendor open source libraries... :(' - diff --git a/run_tests.py b/run_tests.py index bd1587d4..eb26459c 100644 --- a/run_tests.py +++ b/run_tests.py @@ -41,7 +41,7 @@ Due to our use of multiprocessing it we frequently get some ignorable import __main__ import sys -from nova import vendor + from twisted.scripts import trial as trial_script from nova import datastore