x/python-ganttclient
Code Issues Proposed changes

class based singleton for SharedPool

Browse Source
This commit is contained in:
Vishvananda Ishaya
2010-07-26 12:49:21 -07:00
parent a8fd36c867
commit b72e1ef1e8
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
nova/process.py
View File

@@ -205,12 +205,13 @@ class ProcessPool(object):
self._pool.release() self._pool.release()
return rv return rv
_instance = None class SharedPool(object):
def SharedPool(): _instance = None
global _instance def __init__(self):
if _instance is None: if SharedPool._instance is None:
_instance = ProcessPool() self.__class__._instance = ProcessPool()
return _instance def __getattr__(self, key):
return getattr(self._instance, key)
def simple_execute(cmd, **kwargs): def simple_execute(cmd, **kwargs):
return SharedPool().simple_execute(cmd, **kwargs) return SharedPool().simple_execute(cmd, **kwargs)

2
nova/tests/process_unittest.py
View File

@@ -118,7 +118,7 @@ class ProcessTestCase(test.TrialTestCase):
def test_shared_pool_is_singleton(self): def test_shared_pool_is_singleton(self):
pool1 = process.SharedPool() pool1 = process.SharedPool()
pool2 = process.SharedPool() pool2 = process.SharedPool()
self.assert_(id(pool1) == id(pool2)) self.assertEqual(id(pool1._instance), id(pool2._instance))
def test_shared_pool_works_as_singleton(self): def test_shared_pool_works_as_singleton(self):
d1 = process.simple_execute('sleep 1') d1 = process.simple_execute('sleep 1')