x/python-ganttclient
Code Issues Proposed changes

Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname

Browse Source 
Change ISCSIDriver to set volume.provider_location during create_export.
This records the location of the LUN, so that nova-compute does not need
to run the iSCSI discovery code itself.

As part of this, include the IP address of the target (--iscsi_ip_address) in
the provider_location.  This means that we don't use volume's host identifier
(which could be an opaque ID) when trying to connect to the iSCSI target --
we use the admin-specified IP address instead.

The string-join to set provider_location is shared with ZadaraBEDriver,
which was doing something similar.  I've brought that into a helper function.

The docstring for the --host flag has been clarified.

Change-Id: I8402da86345e786a46a4d222ad4d8a4449d2bd3f
This commit is contained in:
Ewan Mellor
2011-11-30 10:34:42 -08:00
parent 73efce46b4
commit dbc1e216e3
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
nova/flags.py
View File

@@ -440,7 +440,8 @@ DEFINE_string('image_service', 'nova.image.glance.GlanceImageService',
'The service to use for retrieving and searching for images.')
DEFINE_string('host', socket.gethostname(),
'name of this node')
'Name of this node. This can be an opaque identifier. It is '
'not necessarily a hostname, FQDN, or IP address.')
DEFINE_string('node_availability_zone', 'nova',
'availability zone of this node')