Merged with trunk, added note about suspicious behaviour

2010-07-30 12:13:20 -07:00
parent 52ab46b7cc c5754b0cd8
commit dc15d9eff2
5 changed files with 9 additions and 10 deletions
--- a/nova/process.py
+++ b/nova/process.py
@@ -107,6 +107,9 @@ class BackRelayWithInput(protocol.ProcessProtocol):
                    reason.trap(error.ProcessDone)
                self.deferred.callback((stdout, stderr))
            except:
+                # This logic is a little suspicious to me (justinsb)...
+                # If the callback throws an exception, then errback will be called also.
+                # However, this is what the unit tests test for...
                self.deferred.errback(UnexpectedErrorOutput(stdout, stderr))
        elif self.onProcessEnded is not None:
            self.onProcessEnded.errback(reason)