x/python-ganttclient
Code Issues Proposed changes

Make sure ec2 mapping raises proper exceptions

Browse Source 
The get commands in the db layer were constructing InstanceNotFound,
VolumeNotFound, and SnapshotNotFound with imporoper kwargs. This
fixes them to raise properly and adds a test to verify that the
exception formatting succeeded.

Fixes bug 1035375

Change-Id: I05a5bb57c047ca2b2f086c70ad12a640f51b2d3a
This commit is contained in:
Vishvananda Ishaya
2012-08-10 09:25:10 -07:00
parent c7e2935f71
commit de66861d09
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
nova/tests/test_db_api.py
View File

@@ -45,6 +45,21 @@ class DbApiTestCase(test.TestCase):
args.update(kwargs)
return db.instance_create(self.context, args)
def test_ec2_ids_not_found_are_printable(self):
def check_exc_format(method):
try:
method(self.context, 'fake')
except Exception as exc:
self.assertTrue('fake' in unicode(exc))
check_exc_format(db.get_ec2_volume_id_by_uuid)
check_exc_format(db.get_volume_uuid_by_ec2_id)
check_exc_format(db.get_ec2_snapshot_id_by_uuid)
check_exc_format(db.get_snapshot_uuid_by_ec2_id)
check_exc_format(db.get_ec2_instance_id_by_uuid)
check_exc_format(db.get_instance_uuid_by_ec2_id)
def test_instance_get_all_by_filters(self):
self.create_instances_with_args()
self.create_instances_with_args()