352b7d2922
The next obvious step in porting to cfg is to define all options using
cfg schemas directly rather than using the flags.DEFINE_* helpers.
This is a large change, but it is almost entirely pure refactoring and
does not result in any functional changes.
The only change to note is that the default values for glance_host,
glance_api_servers and default_publisher_id options are now using opt
value interpolation i.e.
-glance_host=_get_my_ip()
+glance_host='$my_ip'
-glance_api_servers=['%s:%d' % (FLAGS.glance_host, FLAGS.glance_port)]
+glance_api_servers=['$glance_host:$glance_port']
-default_publisher_id=FLAGS.host
+default_publisher_id='$host'
Also note that the lower_bound check on the {report,periodic}_interval
options are no more, but this has been true since cfg was first added.
Change-Id: Ia58c8f0aaf61628bb55b1b8485118a2a9852ed17
73 lines
2.2 KiB
Python
73 lines
2.2 KiB
Python
# Copyright 2011 OpenStack LLC.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from nova.common import cfg
|
|
from nova import flags
|
|
from nova import log as logging
|
|
from nova import utils
|
|
from nova.exception import ClassNotFound
|
|
|
|
|
|
list_notifier_drivers_opt = \
|
|
cfg.MultiStrOpt('list_notifier_drivers',
|
|
default=['nova.notifier.no_op_notifier'],
|
|
help='List of drivers to send notifications')
|
|
|
|
FLAGS = flags.FLAGS
|
|
FLAGS.add_option(list_notifier_drivers_opt)
|
|
|
|
LOG = logging.getLogger('nova.notifier.list_notifier')
|
|
|
|
drivers = None
|
|
|
|
|
|
class ImportFailureNotifier(object):
|
|
"""Noisily re-raises some exception over-and-over when notify is called."""
|
|
|
|
def __init__(self, exception):
|
|
self.exception = exception
|
|
|
|
def notify(self, message):
|
|
raise self.exception
|
|
|
|
|
|
def _get_drivers():
|
|
"""Instantiates and returns drivers based on the flag values."""
|
|
global drivers
|
|
if not drivers:
|
|
drivers = []
|
|
for notification_driver in FLAGS.list_notifier_drivers:
|
|
try:
|
|
drivers.append(utils.import_object(notification_driver))
|
|
except ClassNotFound as e:
|
|
drivers.append(ImportFailureNotifier(e))
|
|
return drivers
|
|
|
|
|
|
def notify(message):
|
|
"""Passes notification to multiple notifiers in a list."""
|
|
for driver in _get_drivers():
|
|
try:
|
|
driver.notify(message)
|
|
except Exception as e:
|
|
LOG.exception(_("Problem '%(e)s' attempting to send to "
|
|
"notification driver %(driver)s." % locals()))
|
|
|
|
|
|
def _reset_drivers():
|
|
"""Used by unit tests to reset the drivers."""
|
|
global drivers
|
|
drivers = None
|