diff --git a/oneview_client/managers.py b/oneview_client/managers.py index f2ced87..570c74c 100644 --- a/oneview_client/managers.py +++ b/oneview_client/managers.py @@ -41,7 +41,10 @@ class OneViewManager(object): pass def list(self, **kwargs): - resource_uri = self.uri_prefix + # NOTE(nicodemos) The OneView API documents that count=-1 should + # return everything but it is not, using an extremely large count + # instead. + resource_uri = self.uri_prefix + '?start=0&count=9999999' resource_json = self.oneview_client._prepare_and_do_request( uri=resource_uri ) @@ -114,7 +117,10 @@ class OneViewIndexManager(object): pass def list(self, **kwargs): - resource_uri = self.uri_index + # NOTE(nicodemos) The OneView API documents that count=-1 should + # return everything but it is not, using an extremely large count + # instead. + resource_uri = self.uri_index + '&start=0&count=9999999' resource_json = self.oneview_client._prepare_and_do_request( uri=resource_uri ) diff --git a/oneview_client/tests/functional/test_oneview_client.py b/oneview_client/tests/functional/test_oneview_client.py index b1af2a6..308f567 100644 --- a/oneview_client/tests/functional/test_oneview_client.py +++ b/oneview_client/tests/functional/test_oneview_client.py @@ -419,7 +419,7 @@ class OneViewClientV2TestCase(unittest.TestCase): server_hardware_list = oneview_client.server_hardware.list() mock_get.assert_called_once_with( - url='https://1.2.3.4/rest/server-hardware/', + url='https://1.2.3.4/rest/server-hardware/?start=0&count=9999999', headers=mock.ANY, verify=True ) @@ -441,7 +441,7 @@ class OneViewClientV2TestCase(unittest.TestCase): server_hardware_list = oneview_client.server_hardware_index.list() mock_get.assert_called_once_with( url='https://1.2.3.4/rest/index/resources?' + - 'category=server-hardware', + 'category=server-hardware&start=0&count=9999999', headers=mock.ANY, verify=True ) @@ -558,7 +558,8 @@ class OneViewClientV2TestCase(unittest.TestCase): oneview_client.server_profile_template.list() ) mock_get.assert_called_once_with( - url='https://1.2.3.4/rest/server-profile-templates/', + url='https://1.2.3.4/rest/server-profile-templates/' + '?start=0&count=9999999', headers=mock.ANY, verify=True ) @@ -637,7 +638,7 @@ class OneViewClientV2TestCase(unittest.TestCase): server_profile_list = oneview_client.server_profile.list() mock_get.assert_called_once_with( - url='https://1.2.3.4/rest/server-profiles/', + url='https://1.2.3.4/rest/server-profiles/?start=0&count=9999999', headers=mock.ANY, verify=True ) diff --git a/oneview_client/tests/unit/test_managers.py b/oneview_client/tests/unit/test_managers.py index 4adebe5..8011eda 100644 --- a/oneview_client/tests/unit/test_managers.py +++ b/oneview_client/tests/unit/test_managers.py @@ -43,7 +43,8 @@ class TestServerHardwareIndexManager(unittest.TestCase): index_manager = managers.ServerHardwareIndexManager(oneview_client) objects = index_manager.list() oneview_client._prepare_and_do_request.assert_called_once_with( - uri=managers.ServerHardwareIndexManager.uri_index + uri=managers.ServerHardwareIndexManager.uri_index + '&start=0' + '&count=9999999' ) for obj in objects: self.assertIsInstance(obj, models.ServerHardware)