x/python-redfish
Code Issues Proposed changes

class functions should be called by 'self.' prefix

Browse Source
This commit is contained in:
Devananda van der Veen
2015-03-25 14:28:30 -07:00
parent a8706d5236
commit fa870ecce7
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
redfish/connection.py
View File

@@ -215,14 +215,15 @@ class RedfishConnection(object):
def rest_get(self, host, suburi, request_headers, user_name, password): def rest_get(self, host, suburi, request_headers, user_name, password):
"""Generic REST GET handler""" """Generic REST GET handler"""
# NOTE: be prepared for various HTTP responses including 500, 404, etc. # NOTE: be prepared for various HTTP responses including 500, 404, etc.
return rest_op('GET', host, suburi, request_headers, None, user_name, password) # XXX need parameter sanitization; request_headers must be a dict or None
return self.rest_op('GET', host, suburi, request_headers, None, user_name, password)
def rest_patch(self, server, suburi, request_headers, request_body, user_name, password): def rest_patch(self, server, suburi, request_headers, request_body, user_name, password):
"""REST PATCH""" """REST PATCH"""
if not isinstance(request_headers, dict): request_headers = dict() if not isinstance(request_headers, dict): request_headers = dict()
request_headers['Content-Type'] = 'application/json' request_headers['Content-Type'] = 'application/json'
return rest_op('PATCH', server, suburi, request_headers, request_body, user_name, password) return self.rest_op('PATCH', server, suburi, request_headers, request_body, user_name, password)
# NOTE: be prepared for various HTTP responses including 500, 404, 202 etc. # NOTE: be prepared for various HTTP responses including 500, 404, 202 etc.
@@ -230,20 +231,20 @@ class RedfishConnection(object):
"""REST PUT""" """REST PUT"""
if not isinstance(request_headers, dict): request_headers = dict() if not isinstance(request_headers, dict): request_headers = dict()
request_headers['Content-Type'] = 'application/json' request_headers['Content-Type'] = 'application/json'
return rest_op('PUT', host, suburi, request_headers, request_body, user_name, password) return self.rest_op('PUT', host, suburi, request_headers, request_body, user_name, password)
# NOTE: be prepared for various HTTP responses including 500, 404, 202 etc. # NOTE: be prepared for various HTTP responses including 500, 404, 202 etc.
# REST POST # REST POST
def rest_post(self, host, suburi, request_headers, request_body, user_name, password): def rest_post(self, host, suburi, request_headers, request_body, user_name, password):
if not isinstance(request_headers, dict): request_headers = dict() if not isinstance(request_headers, dict): request_headers = dict()
request_headers['Content-Type'] = 'application/json' request_headers['Content-Type'] = 'application/json'
return rest_op('POST', host, suburi, request_headers, request_body, user_name, password) return self.rest_op('POST', host, suburi, request_headers, request_body, user_name, password)
# NOTE: don't assume any newly created resource is included in the response. Only the Location header matters. # NOTE: don't assume any newly created resource is included in the response. Only the Location header matters.
# the response body may be the new resource, it may be an ExtendedError, or it may be empty. # the response body may be the new resource, it may be an ExtendedError, or it may be empty.
# REST DELETE # REST DELETE
def rest_delete(self, host, suburi, request_headers, user_name, password): def rest_delete(self, host, suburi, request_headers, user_name, password):
return rest_op('DELETE', host, suburi, request_headers, None, user_name, password) return self.rest_op('DELETE', host, suburi, request_headers, None, user_name, password)
# NOTE: be prepared for various HTTP responses including 500, 404, etc. # NOTE: be prepared for various HTTP responses including 500, 404, etc.
# NOTE: response may be an ExtendedError or may be empty # NOTE: response may be an ExtendedError or may be empty