From 06f9d7f14af3f4f793078ffcb1b915a1c49798d4 Mon Sep 17 00:00:00 2001 From: Dao Cong Tien Date: Thu, 19 Jul 2018 11:40:25 +0700 Subject: [PATCH] Fix bug of missing versions when setting secure boot flag iRMC firmware versions 8.64F and 8.84F or newer require bios config data provided with versions. This patch updates the existing set_secure_boot_mode() as it does not provide versions when setting. Tested on servers with FW 8.43F, 8.64F and 8.84F. Change-Id: I97aa13436c80be311738712a3c36cc4a8beb9e63 (cherry picked from commit ea8d111201243642e2ef6eb10b9af38a6b163fd8) --- scciclient/irmc/elcm.py | 2 ++ scciclient/tests/irmc/test_elcm.py | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/scciclient/irmc/elcm.py b/scciclient/irmc/elcm.py index 3bc5bca..cd4407b 100644 --- a/scciclient/irmc/elcm.py +++ b/scciclient/irmc/elcm.py @@ -703,8 +703,10 @@ def set_secure_boot_mode(irmc_info, enable): bios_config_data = { 'Server': { + '@Version': '1.01', 'SystemConfig': { 'BiosConfig': { + '@Version': '1.01', 'SecurityConfig': { 'SecureBootControlEnabled': enable } diff --git a/scciclient/tests/irmc/test_elcm.py b/scciclient/tests/irmc/test_elcm.py index 498174b..847f6f1 100644 --- a/scciclient/tests/irmc/test_elcm.py +++ b/scciclient/tests/irmc/test_elcm.py @@ -997,8 +997,10 @@ class ELCMTestCase(testtools.TestCase): elcm.set_secure_boot_mode(irmc_info=self.irmc_info, enable=True) bios_config_data = { 'Server': { + '@Version': '1.01', 'SystemConfig': { 'BiosConfig': { + '@Version': '1.01', 'SecurityConfig': { 'SecureBootControlEnabled': True } @@ -1014,8 +1016,10 @@ class ELCMTestCase(testtools.TestCase): elcm.set_secure_boot_mode(irmc_info=self.irmc_info, enable=False) bios_config_data = { 'Server': { + '@Version': '1.01', 'SystemConfig': { 'BiosConfig': { + '@Version': '1.01', 'SecurityConfig': { 'SecureBootControlEnabled': False }