x/python-scciclient
Code Issues Proposed changes

Merge "Encode parameters passed to pyghmi.ipmi.Command"

Browse Source
This commit is contained in:
Zuul
2022-07-15 05:55:36 +00:00
committed by Gerrit Code Review
parent 1dfbad7e14 7b530fa24b
commit 5624f8a68c
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
scciclient/irmc/ipmi.py
View File

@@ -90,9 +90,10 @@ def get_tpm_status(d_info):
# 80 28 00 C0 C0: True # 80 28 00 C0 C0: True
# 80 28 00 -- --: False (other values than 'C0 C0') # 80 28 00 -- --: False (other values than 'C0 C0')
ipmicmd = ipmi_command.Command(bmc=d_info['irmc_address'], ipmicmd = ipmi_command.Command(
userid=d_info['irmc_username'], bmc=d_info['irmc_address'],
password=d_info['irmc_password']) userid=d_info['irmc_username'].encode('utf-8'),
password=d_info['irmc_password'].encode('utf-8'))
try: try:
response = _send_raw_command(ipmicmd, GET_TPM_STATUS) response = _send_raw_command(ipmicmd, GET_TPM_STATUS)
if response['code'] != 0: if response['code'] != 0:
@@ -150,9 +151,10 @@ def get_pci_device(d_info, pci_device_ids):
# data1: 2 octet of VendorID # data1: 2 octet of VendorID
# data2: 2 octet of DeviceID # data2: 2 octet of DeviceID
ipmicmd = ipmi_command.Command(bmc=d_info['irmc_address'], ipmicmd = ipmi_command.Command(
userid=d_info['irmc_username'], bmc=d_info['irmc_address'],
password=d_info['irmc_password']) userid=d_info['irmc_username'].encode('utf-8'),
password=d_info['irmc_password'].encode('utf-8'))
response = itertools.takewhile( response = itertools.takewhile(
lambda y: (y[1]['code'] != 0xC9 and y[1].get('error') is None), lambda y: (y[1]['code'] != 0xC9 and y[1].get('error') is None),