x/quark
Code Issues Proposed changes

Exclude provider subnets from overlapping CIDR validation

Browse Source 
Including the provider subnets as part of the validation caused
a BadRequest as their cidrs span the entire IP space. This would
prevent quark administrators creating any new subnets under provider
networks.

JIRA:NCP-1746
This commit is contained in:
Amir Sadoughi
2015-10-28 15:04:06 +00:00
parent 334686a1dc
commit 78c3b56309
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
quark/plugin_modules/subnets.py
View File

@@ -65,7 +65,8 @@ def _validate_subnet_cidr(context, network_id, new_subnet_cidr):
# Using admin context here, in case we actually share networks later # Using admin context here, in case we actually share networks later
subnet_list = db_api.subnet_find(context.elevated(), None, None, None, subnet_list = db_api.subnet_find(context.elevated(), None, None, None,
False, network_id=network_id) False, network_id=network_id,
shared=[False])
for subnet in subnet_list: for subnet in subnet_list:
if (netaddr.IPSet([subnet.cidr]) & new_subnet_ipset): if (netaddr.IPSet([subnet.cidr]) & new_subnet_ipset):
# don't give out details of the overlapping subnet # don't give out details of the overlapping subnet