From aa060e215406a2744e7c35156486d9e93694243a Mon Sep 17 00:00:00 2001 From: Kyle Haley Date: Thu, 30 Jun 2016 13:46:21 -0700 Subject: [PATCH] Explicitly define allow_put in neutron extensions allow_put is not explicitly defined in quark extensions to existing neutron resources. Defining allow_put in the resource definitions will now throw the proper 400 error. Change-Id: Idc427271c47155ea8ce3310e74028fd64c2a83d2 JIRA:NCP-1989 Closes-Bug: 1597912 --- quark/api/extensions/networks_quark.py | 11 ++++++----- quark/api/extensions/ports_quark.py | 8 ++++---- quark/api/extensions/subnets_quark.py | 3 ++- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/quark/api/extensions/networks_quark.py b/quark/api/extensions/networks_quark.py index 3f4af8b..6265e02 100644 --- a/quark/api/extensions/networks_quark.py +++ b/quark/api/extensions/networks_quark.py @@ -20,11 +20,12 @@ RESOURCE_NAME = "network" RESOURCE_COLLECTION = RESOURCE_NAME + "s" EXTENDED_ATTRIBUTES_2_0 = { RESOURCE_COLLECTION: { - "ipam_strategy": {"allow_post": True, "is_visible": True, - "default": False}, - "network_plugin": {"allow_post": True, "is_visible": False, - "default": False}, - "id": {"allow_post": True, "is_visible": True, "default": False}}} + "ipam_strategy": {"allow_post": True, "allow_put": False, + "is_visible": True, "default": False}, + "network_plugin": {"allow_post": True, "allow_put": False, + "is_visible": False, "default": False}, + "id": {"allow_post": True, "allow_put": False, + "is_visible": True, "default": False}}} class Networks_quark(extensions.ExtensionDescriptor): diff --git a/quark/api/extensions/ports_quark.py b/quark/api/extensions/ports_quark.py index f5400e4..08fe46f 100644 --- a/quark/api/extensions/ports_quark.py +++ b/quark/api/extensions/ports_quark.py @@ -21,10 +21,10 @@ RESOURCE_NAME = "port" RESOURCE_COLLECTION = RESOURCE_NAME + "s" EXTENDED_ATTRIBUTES_2_0 = { RESOURCE_COLLECTION: { - "network_id": {"allow_post": True, "default": '', - "is_visible": True}, - "tenant_id": {"allow_post": True, "default": '', - "is_visible": True}, + "network_id": {"allow_post": True, "allow_put": False, + "default": '', "is_visible": True}, + "tenant_id": {"allow_post": True, "allow_put": False, + "default": '', "is_visible": True}, "segment_id": {"allow_post": True, "default": False}, "bridge": {'allow_post': False, 'allow_put': False, 'default': False, 'is_visible': True}, diff --git a/quark/api/extensions/subnets_quark.py b/quark/api/extensions/subnets_quark.py index d8a08bc..c78e322 100644 --- a/quark/api/extensions/subnets_quark.py +++ b/quark/api/extensions/subnets_quark.py @@ -17,7 +17,8 @@ from neutron.api import extensions EXTENDED_ATTRIBUTES_2_0 = { "subnets": { - "segment_id": {"allow_post": True, "default": None}, + "segment_id": {"allow_post": True, "allow_put": False, + "default": None}, "ip_policy_id": {"allow_post": False, "allow_put": False, "default": None, "is_visible": True} }