x/quark
Code Issues Proposed changes

Fixed http status code when floating ip id is invalid.

Browse Source
This commit is contained in:
Alan Quillin
2015-10-27 18:18:05 -04:00
parent 17d5b13be2
commit f53706c14d
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
quark/exceptions.py
View File

@@ -145,7 +145,7 @@ class NoBackendConnectionsDefined(exceptions.NeutronException):
"definition. %(msg)") "definition. %(msg)")
class FloatingIpNotFound(exceptions.NeutronException): class FloatingIpNotFound(exceptions.NotFound):
message = _("Floating IP %(id)s not found.") message = _("Floating IP %(id)s not found.")

3
quark/plugin_modules/floating_ips.py
View File

@@ -163,10 +163,11 @@ def update_floatingip(context, id, content):
port = None port = None
fixed_ip = None fixed_ip = None
current_port = None current_port = None
flip = None
with context.session.begin(): with context.session.begin():
flip = db_api.floating_ip_find(context, id=id, scope=db_api.ONE) flip = db_api.floating_ip_find(context, id=id, scope=db_api.ONE)
if not flip:
raise qex.FloatingIpNotFound(id=id)
current_ports = flip.ports current_ports = flip.ports