x
/
ramdisk-func-test
Code Issues Proposed changes

Fix read_file and add write_file methods of Node class 

Due to usage of '&&' in bash command joining, if file is missing,
read_file method skips umount step. As result we have a problem with
"busy" mounts.

Add write_file method to complete file manipulation toolbox.

Change-Id: I1f2957c9e6b697b00868c3592ed67e6912b190af
This commit is contained in:
Dmitry Bogun 2016-12-12 18:10:58 +02:00 committed by Andrii Ostapenko
parent 25b14a7f9c
commit 5bb7d8fd3c
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ramdisk_func_test/node.py
View File

@ -96,7 +96,14 @@ class Node(base.LibvirtBase):
out, ret_code = self.run_cmd(
'mount -t {part_type} {partition} /mnt '
'&& cat /mnt/{file} '
'&& umount /mnt'.format(**locals()))
'; umount /mnt'.format(**locals()))
return out
def write_file(self, partition, file, contents, part_type='ext4'):
out, ret_code = self.run_cmd(
'mount -t {part_type} {partition} /mnt '
'&& echo \'{contents}\' > /mnt/{file} '
'; umount /mnt'.format(**locals()))
return out
def run_cmd(self, cmd, check_ret_code=False, get_bareon_log=False):