x
/
sahara-ci-config
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(2 comments)

also, rebase is incorrect

Patch-set: 2
Label: Code-Review=-1
This commit is contained in:
Gerrit User 13919 2017-08-08 12:54:35 +00:00 committed by Gerrit Code Review
parent 1dd2e06ed7
commit 37a0df187d
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
96dd62198a9cf4e4eabcbfc007716f78e5db03ec Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "9f436f4f_3d71f2e1",
"filename": "system-configs/ansible/roles/apache/tasks/main.yml",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 13919
},
"writtenOn": "2017-08-08T12:54:35Z",
"side": 1,
"message": "please, move files from sites-available to roles/apache/templates and use apache-module \"template\" for copy",
"revId": "96dd62198a9cf4e4eabcbfc007716f78e5db03ec",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f436f4f_3d4a1280",
"filename": "system-configs/ansible/roles/apache/tasks/main.yml",
"patchSetId": 2
},
"lineNbr": 19,
"author": {
"id": 13919
},
"writtenOn": "2017-08-08T12:54:35Z",
"side": 1,
"message": "why we need it?",
"revId": "96dd62198a9cf4e4eabcbfc007716f78e5db03ec",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}