x
/
sahara-ci-config
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 10459 <10459@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 10459 2017-08-18 13:24:54 +00:00 committed by Gerrit Code Review
parent 5e6c400b05
commit 8056bf9eb1
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
31f8e3959196b940257abfdd27f2010efae733ac Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "9f436f4f_34c1fa2f",
"filename": "system-configs/ansible/README.rst",
"patchSetId": 2
},
"lineNbr": 9,
"author": {
"id": 10459
},
"writtenOn": "2017-08-18T13:24:54Z",
"side": 1,
"message": "What about defining the dependencies in meta/main.yml? And also, about writing a requirements.yml file?",
"revId": "31f8e3959196b940257abfdd27f2010efae733ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f436f4f_1f196f87",
"filename": "system-configs/ansible/group_vars/localhost",
"patchSetId": 2
},
"lineNbr": 2,
"author": {
"id": 10459
},
"writtenOn": "2017-08-18T13:24:54Z",
"side": 1,
"message": "minor cosmetic and not so important: I wonder if it could be written with one item for line for better readability",
"revId": "31f8e3959196b940257abfdd27f2010efae733ac",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}